Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 67a65de

Browse files
author
Geoffrey Goh
committed
native modules can take enum args!
1 parent 40b8c8e commit 67a65de

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

windows/CodePushNativeModule.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ public void getConfiguration(IPromise promise)
124124
}
125125

126126
[ReactMethod]
127-
public void getUpdateMetadata(int updateState, IPromise promise)
127+
public void getUpdateMetadata(UpdateState updateState, IPromise promise)
128128
{
129129
Action getCurrentPackageAction = async () =>
130130
{
@@ -143,13 +143,13 @@ public void getUpdateMetadata(int updateState, IPromise promise)
143143
currentUpdateIsPending = SettingsManager.IsPendingUpdate(currentHash);
144144
}
145145

146-
if (updateState == (int)UpdateState.Pending && !currentUpdateIsPending)
146+
if (updateState == UpdateState.Pending && !currentUpdateIsPending)
147147
{
148148
// The caller wanted a pending update
149149
// but there isn't currently one.
150150
promise.Resolve("");
151151
}
152-
else if (updateState == (int)UpdateState.Running && currentUpdateIsPending)
152+
else if (updateState == UpdateState.Running && currentUpdateIsPending)
153153
{
154154
// The caller wants the running update, but the current
155155
// one is pending, so we need to grab the previous.
@@ -187,14 +187,14 @@ public void getNewStatusReport(IPromise promise)
187187
}
188188

189189
[ReactMethod]
190-
public void installUpdate(JObject updatePackage, int installMode, int minimumBackgroundDuration, IPromise promise)
190+
public void installUpdate(JObject updatePackage, InstallMode installMode, int minimumBackgroundDuration, IPromise promise)
191191
{
192192
Action installUpdateAction = async () =>
193193
{
194194
await _codePush.UpdateManager.InstallPackage(updatePackage, SettingsManager.IsPendingUpdate(null));
195195
var pendingHash = (string)updatePackage[CodePushConstants.PackageHashKey];
196196
SettingsManager.SavePendingUpdate(pendingHash, /* isLoading */false);
197-
if (installMode == (int)InstallMode.OnNextResume)
197+
if (installMode == InstallMode.OnNextResume)
198198
{
199199
if (_minBackgroundListener == null)
200200
{

0 commit comments

Comments
 (0)