Merge pull request #407 from Microsoft/fix-install-update-twice

No-op in CodePushPackage.m / CodePushUpdateManager.java if the pending update is already installed

Author: geof90

android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateManager.java

@@ -275,6 +275,13 @@ public void downloadPackage(ReadableMap updatePackage, String expectedBundleFile
     public void installPackage(ReadableMap updatePackage, boolean removePendingUpdate) {
         String packageHash = CodePushUtils.tryGetString(updatePackage, CodePushConstants.PACKAGE_HASH_KEY);
         WritableMap info = getCurrentPackageInfo();
+
+        String currentPackageHash = CodePushUtils.tryGetString(info, CodePushConstants.CURRENT_PACKAGE_KEY);
+        if (packageHash != null && packageHash.equals(currentPackageHash)) {
+            // The current package is already the one being installed, so we should no-op.
+            return;
+        }
+
         if (removePendingUpdate) {
             String currentPackageFolderPath = getCurrentPackageFolderPath();
             if (currentPackageFolderPath != null) {

ios/CodePush/CodePushPackage.m

@@ -454,6 +454,11 @@ + (void)installPackage:(NSDictionary *)updatePackage
         return;
     }
 
+    if (packageHash && [packageHash isEqualToString:info[@"currentPackage"]]) {
+        // The current package is already the one being installed, so we should no-op.
+        return;
+    }
+
     if (removePendingUpdate) {
         NSString *currentPackageFolderPath = [self getCurrentPackageFolderPath:error];
         if (!*error && currentPackageFolderPath) {