Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 15cd39c

Browse files
author
Geoffrey Goh
committed
update API
1 parent 4fd3dec commit 15cd39c

9 files changed

+275
-32
lines changed

windows/.npmignore

Lines changed: 252 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,252 @@
1+
## Ignore Visual Studio temporary files, build results, and
2+
## files generated by popular Visual Studio add-ons.
3+
4+
# User-specific files
5+
*.suo
6+
*.user
7+
*.userosscache
8+
*.sln.docstates
9+
10+
# User-specific files (MonoDevelop/Xamarin Studio)
11+
*.userprefs
12+
13+
# Build results
14+
[Dd]ebug/
15+
[Dd]ebugPublic/
16+
[Rr]elease/
17+
[Rr]eleases/
18+
x64/
19+
x86/
20+
bld/
21+
[Bb]in/
22+
[Oo]bj/
23+
[Ll]og/
24+
25+
# Visual Studio 2015 cache/options directory
26+
.vs/
27+
# Uncomment if you have tasks that create the project's static files in wwwroot
28+
#wwwroot/
29+
30+
# MSTest test Results
31+
[Tt]est[Rr]esult*/
32+
[Bb]uild[Ll]og.*
33+
34+
# NUNIT
35+
*.VisualState.xml
36+
TestResult.xml
37+
38+
# Build Results of an ATL Project
39+
[Dd]ebugPS/
40+
[Rr]eleasePS/
41+
dlldata.c
42+
43+
# DNX
44+
project.lock.json
45+
artifacts/
46+
47+
*_i.c
48+
*_p.c
49+
*_i.h
50+
*.ilk
51+
*.meta
52+
*.obj
53+
*.pch
54+
*.pdb
55+
*.pgc
56+
*.pgd
57+
*.rsp
58+
*.sbr
59+
*.tlb
60+
*.tli
61+
*.tlh
62+
*.tmp
63+
*.tmp_proj
64+
*.log
65+
*.vspscc
66+
*.vssscc
67+
.builds
68+
*.pidb
69+
*.svclog
70+
*.scc
71+
72+
# Chutzpah Test files
73+
_Chutzpah*
74+
75+
# Visual C++ cache files
76+
ipch/
77+
*.aps
78+
*.ncb
79+
*.opendb
80+
*.opensdf
81+
*.sdf
82+
*.cachefile
83+
*.VC.db
84+
*.VC.VC.opendb
85+
86+
# Visual Studio profiler
87+
*.psess
88+
*.vsp
89+
*.vspx
90+
*.sap
91+
92+
# TFS 2012 Local Workspace
93+
$tf/
94+
95+
# Guidance Automation Toolkit
96+
*.gpState
97+
98+
# ReSharper is a .NET coding add-in
99+
_ReSharper*/
100+
*.[Rr]e[Ss]harper
101+
*.DotSettings.user
102+
103+
# JustCode is a .NET coding add-in
104+
.JustCode
105+
106+
# TeamCity is a build add-in
107+
_TeamCity*
108+
109+
# DotCover is a Code Coverage Tool
110+
*.dotCover
111+
112+
# NCrunch
113+
_NCrunch_*
114+
.*crunch*.local.xml
115+
nCrunchTemp_*
116+
117+
# MightyMoose
118+
*.mm.*
119+
AutoTest.Net/
120+
121+
# Web workbench (sass)
122+
.sass-cache/
123+
124+
# Installshield output folder
125+
[Ee]xpress/
126+
127+
# DocProject is a documentation generator add-in
128+
DocProject/buildhelp/
129+
DocProject/Help/*.HxT
130+
DocProject/Help/*.HxC
131+
DocProject/Help/*.hhc
132+
DocProject/Help/*.hhk
133+
DocProject/Help/*.hhp
134+
DocProject/Help/Html2
135+
DocProject/Help/html
136+
137+
# Click-Once directory
138+
publish/
139+
140+
# Publish Web Output
141+
*.[Pp]ublish.xml
142+
*.azurePubxml
143+
# TODO: Comment the next line if you want to checkin your web deploy settings
144+
# but database connection strings (with potential passwords) will be unencrypted
145+
*.pubxml
146+
*.publishproj
147+
148+
# Microsoft Azure Web App publish settings. Comment the next line if you want to
149+
# checkin your Azure Web App publish settings, but sensitive information contained
150+
# in these scripts will be unencrypted
151+
PublishScripts/
152+
153+
# NuGet Packages
154+
*.nupkg
155+
# The packages folder can be ignored because of Package Restore
156+
**/packages/*
157+
# except build/, which is used as an MSBuild target.
158+
!**/packages/build/
159+
# Uncomment if necessary however generally it will be regenerated when needed
160+
#!**/packages/repositories.config
161+
# NuGet v3's project.json files produces more ignoreable files
162+
*.nuget.props
163+
*.nuget.targets
164+
165+
# Microsoft Azure Build Output
166+
csx/
167+
*.build.csdef
168+
169+
# Microsoft Azure Emulator
170+
ecf/
171+
rcf/
172+
173+
# Windows Store app package directories and files
174+
AppPackages/
175+
BundleArtifacts/
176+
Package.StoreAssociation.xml
177+
_pkginfo.txt
178+
179+
# Visual Studio cache files
180+
# files ending in .cache can be ignored
181+
*.[Cc]ache
182+
# but keep track of directories ending in .cache
183+
!*.[Cc]ache/
184+
185+
# Others
186+
ClientBin/
187+
~$*
188+
*~
189+
*.dbmdl
190+
*.dbproj.schemaview
191+
*.pfx
192+
*.publishsettings
193+
node_modules/
194+
orleans.codegen.cs
195+
196+
# Since there are multiple workflows, uncomment next line to ignore bower_components
197+
# (https://github.com/github/gitignore/pull/1529#issuecomment-104372622)
198+
#bower_components/
199+
200+
# RIA/Silverlight projects
201+
Generated_Code/
202+
203+
# Backup & report files from converting an old project file
204+
# to a newer Visual Studio version. Backup files are not needed,
205+
# because we have git ;-)
206+
_UpgradeReport_Files/
207+
Backup*/
208+
UpgradeLog*.XML
209+
UpgradeLog*.htm
210+
211+
# SQL Server files
212+
*.mdf
213+
*.ldf
214+
215+
# Business Intelligence projects
216+
*.rdl.data
217+
*.bim.layout
218+
*.bim_*.settings
219+
220+
# Microsoft Fakes
221+
FakesAssemblies/
222+
223+
# GhostDoc plugin setting file
224+
*.GhostDoc.xml
225+
226+
# Node.js Tools for Visual Studio
227+
.ntvs_analysis.dat
228+
229+
# Visual Studio 6 build log
230+
*.plg
231+
232+
# Visual Studio 6 workspace options file
233+
*.opt
234+
235+
# Visual Studio LightSwitch build output
236+
**/*.HTMLClient/GeneratedArtifacts
237+
**/*.DesktopClient/GeneratedArtifacts
238+
**/*.DesktopClient/ModelManifest.xml
239+
**/*.Server/GeneratedArtifacts
240+
**/*.Server/ModelManifest.xml
241+
_Pvt_Extensions
242+
243+
# Paket dependency manager
244+
.paket/paket.exe
245+
paket-files/
246+
247+
# FAKE - F# Make
248+
.fake/
249+
250+
# JetBrains Rider
251+
.idea/
252+
*.sln.iml

windows/CodePush.cs

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
using ReactNative.Bridge;
44
using ReactNative.Modules.Core;
55
using ReactNative.UIManager;
6-
using Windows.UI.Xaml.Controls;
7-
using System.Xml;
86
using Windows.ApplicationModel;
97
using Windows.Storage;
108
using System.IO;
@@ -13,13 +11,12 @@
1311
using Newtonsoft.Json;
1412
using System.Reflection;
1513
using Windows.Web.Http;
16-
using System.Linq;
17-
using System.Text.RegularExpressions;
1814
using Windows.Storage.FileProperties;
15+
using ReactNative;
1916

20-
namespace ReactNative.CodePush
17+
namespace CodePush.ReactNative
2118
{
22-
public class CodePush : IReactPackage
19+
public class CodePushModule : IReactPackage
2320
{
2421
private static bool needToReportRollback = false;
2522
private static bool isRunningBinaryVersion = false;
@@ -55,9 +52,9 @@ public class CodePush : IReactPackage
5552

5653
private ReactPage mainPage;
5754

58-
private static CodePush currentInstance;
55+
private static CodePushModule currentInstance;
5956

60-
public CodePush(string deploymentKey, ReactPage mainPage)
57+
public CodePushModule(string deploymentKey, ReactPage mainPage)
6158
{
6259
codePushPackage = new CodePushPackage();
6360
// TODO implement telemetryManager
@@ -98,22 +95,22 @@ private async Task<long> GetBinaryResourcesModifiedTime()
9895
return fileProperties.DateModified.ToUnixTimeMilliseconds();
9996
}
10097

101-
public string GetBundleUrl()
98+
public string GetJavaScriptBundleFile()
10299
{
103-
return GetBundleUrl(DEFAULT_JS_BUNDLE_NAME);
100+
return GetJavaScriptBundleFile(DEFAULT_JS_BUNDLE_NAME);
104101
}
105102

106-
public string GetBundleUrl(string assetsBundleFileName)
103+
public string GetJavaScriptBundleFile(string assetsBundleFileName)
107104
{
108105
if (currentInstance == null)
109106
{
110107
throw new CodePushNotInitializedException("A CodePush instance has not been created yet. Have you added it to your app's list of ReactPackages?");
111108
}
112109

113-
return currentInstance.GetBundleUrlInternal(assetsBundleFileName).Result;
110+
return currentInstance.GetJavaScriptBundleFileAsync(assetsBundleFileName).Result;
114111
}
115112

116-
public async Task<string> GetBundleUrlInternal(string assetsBundleFileName)
113+
public async Task<string> GetJavaScriptBundleFileAsync(string assetsBundleFileName)
117114
{
118115
this.assetsBundleFileName = assetsBundleFileName;
119116
string binaryJsBundleUrl = ASSETS_BUNDLE_PREFIX + assetsBundleFileName;
@@ -376,9 +373,9 @@ public void OnSuspend()
376373
}
377374

378375
// TODO get rid of this
379-
private CodePush codePush;
376+
private CodePushModule codePush;
380377

381-
public CodePushNativeModule(ReactContext reactContext, CodePush codePush) : base(reactContext)
378+
public CodePushNativeModule(ReactContext reactContext, CodePushModule codePush) : base(reactContext)
382379
{
383380
this.reactContext = reactContext;
384381
this.codePush = codePush;
@@ -422,7 +419,7 @@ private async Task LoadBundle()
422419

423420
// #2) Update the locally stored JS bundle file path
424421
Type reactInstanceManagerType = typeof(ReactInstanceManager);
425-
string latestJSBundleFile = await codePush.GetBundleUrlInternal(codePush.assetsBundleFileName);
422+
string latestJSBundleFile = await codePush.GetJavaScriptBundleFileAsync(codePush.assetsBundleFileName);
426423
reactInstanceManagerType
427424
.GetField("_jsBundleFile", BindingFlags.NonPublic | BindingFlags.Instance)
428425
.SetValue(reactInstanceManager, latestJSBundleFile);

windows/CodePushInvalidUpdateException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
using System;
22

3-
namespace ReactNative.CodePush
3+
namespace CodePush.ReactNative
44
{
55
class CodePushInvalidUpdateException : Exception
66
{

windows/CodePushNotInitializedException.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
using System;
22

3-
namespace ReactNative.CodePush
3+
namespace CodePush.ReactNative
44
{
5-
public class CodePushNotInitializedException : Exception
5+
class CodePushNotInitializedException : Exception
66
{
77
public CodePushNotInitializedException(string message)
88
: base(message)

windows/CodePushPackage.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
using Windows.Storage.Streams;
1010
using Windows.Web.Http;
1111

12-
namespace ReactNative.CodePush
12+
namespace CodePush.ReactNative
1313
{
1414
class CodePushPackage
1515
{

windows/CodePushUnknownException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
using System;
22

3-
namespace ReactNative.CodePush
3+
namespace CodePush.ReactNative
44
{
55
class CodePushUnknownException : Exception
66
{

windows/CodePushUpdateUtils.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
using System.Threading.Tasks;
55
using Windows.Storage;
66

7-
namespace ReactNative.CodePush
7+
namespace CodePush.ReactNative
88
{
99
class CodePushUpdateUtils
1010
{

0 commit comments

Comments
 (0)