Defined labels for "python.analysis.logLevel" setting use inconsistent capitalization #2692
Replies: 5 comments
-
This setting is defined in the core extension, and is used by MPLS where I believe that it is actually case sensitive. I agree that it's inconsistent and would prefer lowercase, but there's also not a super clean way of mending this that won't also annoy everyone who's already set their levels. Perhaps that doesn't matter too much; it's just a logging setting. |
Beta Was this translation helpful? Give feedback.
-
Issue addressed in #353 |
Beta Was this translation helpful? Give feedback.
-
#353 was for inconsistent values, this is about capitalization which I think we still want to do eventually anyway. |
Beta Was this translation helpful? Give feedback.
-
With the deprecation of MPLS next month, this setting has been moved into Pylance's extension, so this should now be unblocked if we wanted to change this. |
Beta Was this translation helpful? Give feedback.
-
Moving this issue to discussion as an enhancement request for comments and upvotes. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Pylance's package.json defines the "python.analysis.logLevel" as an enum that allows four values: "Error", "Warning", "Info" and "Trace".
Pyright's package.json defines the same enum but uses "error", "warning", "info" and "trace".
The code supports both, but the JSON settings editor is case-sensitive and reports a warning if you use the wrong case. We should switch one or the other for consistency. I would argue that lowercase is better because it's consistent with enums used in other settings such as "python.analysis.diagnosticSeverityOverrides" (which uses values named "none", "warning", "information" and "error").
Beta Was this translation helpful? Give feedback.
All reactions