Skip to content

Commit fe485ca

Browse files
chore: install browsers deps using cli (#597)
1 parent 1b27a4c commit fe485ca

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ jobs:
1616
runs-on: ubuntu-latest
1717
steps:
1818
- uses: actions/checkout@v2
19-
- uses: microsoft/playwright-github-action@v1
2019
- name: Set up Python
2120
uses: actions/setup-python@v2
2221
with:
@@ -26,8 +25,8 @@ jobs:
2625
python -m pip install --upgrade pip
2726
pip install -r local-requirements.txt
2827
pip install -e .
29-
- name: Build package
30-
run: python setup.py bdist_wheel
28+
python setup.py bdist_wheel
29+
python -m playwright install-deps
3130
- name: Install browsers
3231
run: python -m playwright install
3332
- name: Lint
@@ -74,18 +73,17 @@ jobs:
7473
runs-on: ${{ matrix.os }}
7574
steps:
7675
- uses: actions/checkout@v2
77-
- uses: microsoft/playwright-github-action@v1
7876
- name: Set up Python
7977
uses: actions/setup-python@v2
8078
with:
8179
python-version: ${{ matrix.python-version }}
8280
- name: Install dependencies
8381
run: |
84-
python -m pip install --upgrade pip wheel
82+
python -m pip install --upgrade pip
8583
pip install -r local-requirements.txt
8684
pip install -e .
87-
- name: Build package
88-
run: python setup.py bdist_wheel
85+
python setup.py bdist_wheel
86+
python -m playwright install-deps
8987
- name: Install browsers
9088
run: python -m playwright install
9189
- name: Common Tests
@@ -123,18 +121,17 @@ jobs:
123121
shell: powershell
124122
run: Install-WindowsFeature Server-Media-Foundation
125123
- uses: actions/checkout@v2
126-
- uses: microsoft/playwright-github-action@v1
127124
- name: Set up Python
128125
uses: actions/setup-python@v2
129126
with:
130127
python-version: 3.8
131128
- name: Install dependencies
132129
run: |
133-
python -m pip install --upgrade pip wheel
130+
python -m pip install --upgrade pip
134131
pip install -r local-requirements.txt
135132
pip install -e .
136-
- name: Build package
137-
run: python setup.py bdist_wheel
133+
python setup.py bdist_wheel
134+
python -m playwright install-deps
138135
- name: Install ffmpeg
139136
run: python -m playwright install ffmpeg
140137
- name: Common Tests
@@ -158,7 +155,6 @@ jobs:
158155
timeout-minutes: 30
159156
steps:
160157
- uses: actions/checkout@v2
161-
- uses: microsoft/playwright-github-action@v1
162158
- name: Set up Node.js
163159
uses: actions/setup-node@v1
164160
with:
@@ -172,7 +168,7 @@ jobs:
172168
python -m pip install --upgrade pip
173169
pip install -r local-requirements.txt
174170
pip install -e .
175-
- name: Build package
176-
run: python setup.py bdist_wheel
171+
python setup.py bdist_wheel
172+
python -m playwright install-deps
177173
- name: Test package installation
178174
run: bash buildbots/test-package-installations.sh

.github/workflows/publish.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ jobs:
77
runs-on: ubuntu-latest
88
steps:
99
- uses: actions/checkout@v2
10-
- uses: microsoft/playwright-github-action@v1
1110
- name: Set up Node.js
1211
uses: actions/setup-node@v1
1312
with:
@@ -21,8 +20,8 @@ jobs:
2120
python -m pip install --upgrade pip
2221
pip install -r local-requirements.txt
2322
pip install -e .
24-
- name: Build package
25-
run: python setup.py bdist_wheel
23+
python setup.py bdist_wheel
24+
python -m playwright install-deps
2625
- name: Publish package
2726
env:
2827
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}

0 commit comments

Comments
 (0)