chore: added tests for generation scripts (#99)

Author: mxschmitt

.github/workflows/ci.yml

@@ -75,7 +75,7 @@ jobs:
     - name: Install
       run: python -m playwright install
     - name: Test
-      run: pytest -vv --browser=${{ matrix.browser }} --junitxml=junit/test-results-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.browser }}.xml --cov=playwright --cov-report xml
+      run: pytest -vv --browser=${{ matrix.browser }} --junitxml=junit/test-results-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.browser }}.xml --cov=playwright --cov=scripts --cov-report xml
     - name: Coveralls
       run: coveralls
       env:

buildbots/test-sync-generation.sh

@@ -1,15 +1,19 @@
 #!/bin/bash
 
-newfile="sync_api.py"
-oldfile="playwright/sync_api.py"
+function assert_script {
+    newfile="$2"
+    oldfile="playwright/$2"
+    echo "Testing $newfile against $oldfile"
 
-python scripts/generate_sync_api.py > $newfile
+    python $1 > $newfile
 
-pre-commit run --files $newfile
+    pre-commit run --files $newfile
 
-cmp $oldfile $newfile
-exit_code=$?
+    cmp $oldfile $newfile
+    exit_code=$?
+    rm $newfile
+    return $exit_code
+}
 
-rm $newfile
-
-exit $exit_code
+assert_script "scripts/generate_sync_api.py" "sync_api.py"
+assert_script "scripts/generate_async_api.py" "async_api.py"

playwright/transport.py

@@ -71,5 +71,6 @@ def send(self, message: Dict) -> None:
         if "DEBUGP" in os.environ:  # pragma: no cover
             print("\x1b[32mSEND>\x1b[0m", json.dumps(message, indent=2))
         data = bytes(msg, "utf-8")
-        self._output.write(len(data).to_bytes(4, byteorder="little", signed=False))
-        self._output.write(data)
+        self._output.write(
+            len(data).to_bytes(4, byteorder="little", signed=False) + data
+        )

tests/test_generation.py

@@ -0,0 +1,27 @@
+import sys
+from io import StringIO
+from unittest.mock import patch
+
+import pytest
+
+CAN_RUN_GENERATION_SCRIPT = sys.version_info >= (3, 8)
+
+if CAN_RUN_GENERATION_SCRIPT:
+    from scripts.generate_async_api import main as generate_async_api
+    from scripts.generate_sync_api import main as generate_sync_api
+
+
+@pytest.mark.skipif(
+    not CAN_RUN_GENERATION_SCRIPT, reason="requires python3.8 or higher"
+)
+def test_generate_sync_api():
+    with patch("sys.stdout", new_callable=StringIO):
+        generate_sync_api()
+
+
+@pytest.mark.skipif(
+    not CAN_RUN_GENERATION_SCRIPT, reason="requires python3.8 or higher"
+)
+def test_generate_async_api():
+    with patch("sys.stdout", new_callable=StringIO):
+        generate_async_api()