Skip to content

Commit f5f145f

Browse files
authored
devops: fix Docker canary publishing/building (#2168)
1 parent fc91dfd commit f5f145f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

utils/docker/Dockerfile.jammy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ RUN mkdir /ms-playwright && \
4343
# if its arm64 then install the manylinux1_aarch64 pip package
4444
if [ "$(uname -m)" = "aarch64" ]; then pip install /tmp/*manylinux_2_17_aarch64*.whl; fi && \
4545
playwright mark-docker-image "${DOCKER_IMAGE_NAME_TEMPLATE}" && \
46+
playwright install --with-deps && rm -rf /var/lib/apt/lists/* && \
4647
# Workaround for https://github.com/microsoft/playwright/issues/27313
4748
# While the gstreamer plugin load process can be in-process, it ended up throwing
4849
# an error that it can't have libsoup2 and libsoup3 in the same process because
@@ -52,7 +53,6 @@ RUN mkdir /ms-playwright && \
5253
else \
5354
rm /usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstwebrtc.so; \
5455
fi && \
55-
playwright install --with-deps && rm -rf /var/lib/apt/lists/* && \
5656
rm /tmp/*.whl && \
5757
rm -rf /ms-playwright-agent && \
5858
chmod -R 777 /ms-playwright

utils/docker/publish_docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ if [[ "${RELEASE_CHANNEL}" == "stable" ]]; then
1616
exit 1
1717
fi
1818
elif [[ "${RELEASE_CHANNEL}" == "canary" ]]; then
19-
if [[ "${PW_VERSION}" != *post* ]]; then
19+
if [[ "${PW_VERSION}" != *dev* ]]; then
2020
echo "ERROR: cannot publish canary docker with Playwright version '${PW_VERSION}'"
2121
exit 1
2222
fi

0 commit comments

Comments
 (0)