chore: bump linters (pre-commit) (#1624)

mxschmitt · web-flow · commit f123f8f64bab · 2022-11-02T14:23:14.000-07:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -15,14 +15,14 @@ repos:
       - id: check-executables-have-shebangs
       - id: check-merge-conflict
   - repo: https://github.com/psf/black
-    rev: 22.6.0
+    rev: 22.10.0
     hooks:
       - id: black
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.971
+    rev: v0.982
     hooks:
       - id: mypy
-        additional_dependencies: [types-pyOpenSSL==21.0.3]
+        additional_dependencies: [types-pyOpenSSL==22.1.0.1]
         exclude: examples/
   - repo: https://github.com/pycqa/flake8
     rev: 5.0.4
@@ -40,4 +40,4 @@ repos:
         language: node
         pass_filenames: false
         types: [python]
-        additional_dependencies: ["pyright@1.1.210"]
+        additional_dependencies: ["pyright@1.1.278"]
diff --git a/playwright/_impl/__pyinstaller/hook-playwright.async_api.py b/playwright/_impl/__pyinstaller/hook-playwright.async_api.py
@@ -12,6 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from PyInstaller.utils.hooks import collect_data_files
+from PyInstaller.utils.hooks import collect_data_files  # type: ignore
 
 datas = collect_data_files("playwright")
diff --git a/playwright/_impl/__pyinstaller/hook-playwright.sync_api.py b/playwright/_impl/__pyinstaller/hook-playwright.sync_api.py
@@ -12,6 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from PyInstaller.utils.hooks import collect_data_files
+from PyInstaller.utils.hooks import collect_data_files  # type: ignore
 
 datas = collect_data_files("playwright")
diff --git a/pyproject.toml b/pyproject.toml
@@ -37,3 +37,6 @@ pythonVersion = "3.7"
 reportMissingImports = false
 reportTypedDictNotRequiredAccess = false
 reportCallInDefaultInitializer = true
+reportOptionalSubscript = false
+reportUnboundVariable = false
+strictParameterNoneValue = false
diff --git a/tests/async/test_browsercontext.py b/tests/async/test_browsercontext.py
@@ -681,7 +681,7 @@ async def test_page_event_should_have_an_opener(context, server):
     page = await context.new_page()
     await page.goto(server.EMPTY_PAGE)
     async with context.expect_page() as page_info:
-        await page.goto(server.PREFIX + "/popup/window-open.html"),
+        await page.goto(server.PREFIX + "/popup/window-open.html")
     popup = await page_info.value
     assert popup.url == server.PREFIX + "/popup/popup.html"
     assert await popup.opener() == page
diff --git a/tests/async/test_console.py b/tests/async/test_console.py
@@ -111,7 +111,7 @@ async def test_console_should_trigger_correct_log(page, server):
 async def test_console_should_have_location_for_console_api_calls(page, server):
     await page.goto(server.EMPTY_PAGE)
     async with page.expect_console_message() as message_info:
-        await page.goto(server.PREFIX + "/consolelog.html"),
+        await page.goto(server.PREFIX + "/consolelog.html")
     message = await message_info.value
     assert message.text == "yellow"
     assert message.type == "log"
diff --git a/tests/async/test_device_descriptors.py b/tests/async/test_device_descriptors.py
@@ -21,15 +21,15 @@ async def test_should_work(playwright, launch_arguments) -> None:
 
     assert device_descriptor["viewport"]["height"] > 700
     assert device_descriptor["viewport"]["height"] < 800
-    inner_height = await page.evaluate("window.innerHeight")
-    inner_height > 700
-    inner_height < 800
+    inner_height = await page.evaluate("window.screen.availHeight")
+    assert inner_height > 700
+    assert inner_height < 800
 
     assert device_descriptor["viewport"]["width"] > 400
     assert device_descriptor["viewport"]["width"] < 500
-    inner_width = await page.evaluate("window.innerWidth")
-    inner_width > 400
-    inner_width < 500
+    inner_width = await page.evaluate("window.screen.availWidth")
+    assert inner_width > 400
+    assert inner_width < 500
 
     assert device_descriptor["has_touch"]
     assert device_descriptor["is_mobile"]
diff --git a/tests/async/test_geolocation.py b/tests/async/test_geolocation.py
@@ -112,9 +112,9 @@ async def test_watch_position_should_be_notified(page, server, context):
         await context.set_geolocation({"latitude": 40, "longitude": 50})
 
     all_messages = "|".join(messages)
-    "latitude=0 lng=10" in all_messages
-    "latitude=20 lng=30" in all_messages
-    "latitude=40 lng=50" in all_messages
+    assert "lat=0 lng=10" in all_messages
+    assert "lat=20 lng=30" in all_messages
+    assert "lat=40 lng=50" in all_messages
 
 
 async def test_should_use_context_options_for_popup(page, context, server):
diff --git a/tests/async/test_interception.py b/tests/async/test_interception.py
@@ -103,7 +103,7 @@ async def test_page_route_should_work_when_POST_is_redirected_with_302(page, ser
     """
     )
     async with page.expect_navigation():
-        await page.eval_on_selector("form", "form => form.submit()"),
+        await page.eval_on_selector("form", "form => form.submit()")
 
 
 # @see https://github.com/GoogleChrome/puppeteer/issues/3973
diff --git a/tests/async/test_locators.py b/tests/async/test_locators.py
@@ -327,7 +327,7 @@ async def test_locators_should_upload_a_file(page: Page, server: Server):
 async def test_locators_should_press(page: Page):
     await page.set_content("<input type='text' />")
     await page.locator("input").press("h")
-    await page.eval_on_selector("input", "input => input.value") == "h"
+    assert await page.eval_on_selector("input", "input => input.value") == "h"
 
 
 async def test_locators_should_scroll_into_view(page: Page, server: Server):
@@ -363,7 +363,7 @@ async def test_locators_should_select_textarea(
 async def test_locators_should_type(page: Page):
     await page.set_content("<input type='text' />")
     await page.locator("input").type("hello")
-    await page.eval_on_selector("input", "input => input.value") == "hello"
+    assert await page.eval_on_selector("input", "input => input.value") == "hello"
 
 
 async def test_locators_should_screenshot(
diff --git a/tests/async/test_navigation.py b/tests/async/test_navigation.py
@@ -464,7 +464,7 @@ async def test_wait_for_nav_should_work_with_clicking_on_anchor_links(page, serv
     await page.goto(server.EMPTY_PAGE)
     await page.set_content('<a href="#foobar">foobar</a>')
     async with page.expect_navigation() as response_info:
-        await page.click("a"),
+        await page.click("a")
     response = await response_info.value
     assert response is None
     assert page.url == server.EMPTY_PAGE + "#foobar"
@@ -477,7 +477,7 @@ async def test_wait_for_nav_should_work_with_clicking_on_links_which_do_not_comm
     await page.set_content(f"<a href='{https_server.EMPTY_PAGE}'>foobar</a>")
     with pytest.raises(Error) as exc_info:
         async with page.expect_navigation():
-            await page.click("a"),
+            await page.click("a")
     expect_ssl_error(exc_info.value.message, browser_name)
 
 
@@ -492,7 +492,7 @@ async def test_wait_for_nav_should_work_with_history_push_state(page, server):
     """
     )
     async with page.expect_navigation() as response_info:
-        await page.click("a"),
+        await page.click("a")
     response = await response_info.value
     assert response is None
     assert page.url == server.PREFIX + "/wow.html"
@@ -509,7 +509,7 @@ async def test_wait_for_nav_should_work_with_history_replace_state(page, server)
     """
     )
     async with page.expect_navigation() as response_info:
-        await page.click("a"),
+        await page.click("a")
     response = await response_info.value
     assert response is None
     assert page.url == server.PREFIX + "/replaced.html"
@@ -531,12 +531,12 @@ async def test_wait_for_nav_should_work_with_dom_history_back_forward(page, serv
     )
     assert page.url == server.PREFIX + "/second.html"
     async with page.expect_navigation() as back_response_info:
-        await page.click("a#back"),
+        await page.click("a#back")
     back_response = await back_response_info.value
     assert back_response is None
     assert page.url == server.PREFIX + "/first.html"
     async with page.expect_navigation() as forward_response_info:
-        await page.click("a#forward"),
+        await page.click("a#forward")
     forward_response = await forward_response_info.value
     assert forward_response is None
     assert page.url == server.PREFIX + "/second.html"
diff --git a/tests/async/test_page.py b/tests/async/test_page.py
@@ -174,15 +174,15 @@ async def test_async_stacks_should_work(page, server):
 
 async def test_opener_should_provide_access_to_the_opener_page(page):
     async with page.expect_popup() as popup_info:
-        await page.evaluate("window.open('about:blank')"),
+        await page.evaluate("window.open('about:blank')")
     popup = await popup_info.value
     opener = await popup.opener()
     assert opener == page
 
 
 async def test_opener_should_return_null_if_parent_page_has_been_closed(page):
     async with page.expect_popup() as popup_info:
-        await page.evaluate("window.open('about:blank')"),
+        await page.evaluate("window.open('about:blank')")
     popup = await popup_info.value
     await page.close()
     opener = await popup.opener()
diff --git a/tests/async/test_popup.py b/tests/async/test_popup.py
@@ -54,7 +54,7 @@ async def handle_request(route: Route) -> None:
 
     await context.route("**/empty.html", handle_request)
     async with context.expect_page():
-        await page.click("a"),
+        await page.click("a")
     assert intercepted == [True]
 
 
diff --git a/tests/async/test_wait_for_url.py b/tests/async/test_wait_for_url.py
@@ -102,11 +102,11 @@ async def test_wait_for_url_should_work_with_dom_history_back_forward(
 
     assert page.url == server.PREFIX + "/second.html"
 
-    await page.click("a#back"),
+    await page.click("a#back")
     await page.wait_for_url("**/first.html")
     assert page.url == server.PREFIX + "/first.html"
 
-    await page.click("a#forward"),
+    await page.click("a#forward")
     await page.wait_for_url("**/second.html")
     assert page.url == server.PREFIX + "/second.html"
 
diff --git a/tests/async/test_worker.py b/tests/async/test_worker.py
@@ -139,7 +139,7 @@ async def test_workers_should_clear_upon_cross_process_navigation(server, page):
 
 async def test_workers_should_report_network_activity(page, server):
     async with page.expect_worker() as worker_info:
-        await page.goto(server.PREFIX + "/worker/worker.html"),
+        await page.goto(server.PREFIX + "/worker/worker.html")
     worker = await worker_info.value
     url = server.PREFIX + "/one-style.css"
     async with page.expect_request(url) as request_info, page.expect_response(
diff --git a/tests/sync/test_browsercontext_request_fallback.py b/tests/sync/test_browsercontext_request_fallback.py
@@ -290,7 +290,7 @@ def test_should_amend_post_data(
     context.route("**/*", lambda route: route.fallback(post_data="doggo"))
 
     with server.expect_request("/sleep.zzz") as server_request_info:
-        page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })"),
+        page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })")
     server_request = server_request_info.value
     assert post_data == ["doggo"]
     assert server_request.post_body == b"doggo"
diff --git a/tests/sync/test_console.py b/tests/sync/test_console.py
@@ -24,7 +24,7 @@ def test_console_should_work(page: Page, browser_name: str) -> None:
     messages: List[ConsoleMessage] = []
     page.once("console", lambda m: messages.append(m))
     with page.expect_console_message():
-        page.evaluate('() => console.log("hello", 5, {foo: "bar"})'),
+        page.evaluate('() => console.log("hello", 5, {foo: "bar"})')
     assert len(messages) == 1
     message = messages[0]
     if browser_name != "firefox":
@@ -108,7 +108,7 @@ def test_console_should_not_fail_for_window_object(
 def test_console_should_trigger_correct_Log(page: Page, server: Server) -> None:
     page.goto("about:blank")
     with page.expect_console_message() as message:
-        page.evaluate("url => fetch(url).catch(e => {})", server.EMPTY_PAGE),
+        page.evaluate("url => fetch(url).catch(e => {})", server.EMPTY_PAGE)
     assert "Access-Control-Allow-Origin" in message.value.text
     assert message.value.type == "error"
 
diff --git a/tests/sync/test_fetch_global.py b/tests/sync/test_fetch_global.py
@@ -79,7 +79,7 @@ def test_should_propagate_extra_http_headers_with_redirects(
     with server.expect_request("/a/redirect1") as server_req1:
         with server.expect_request("/b/c/redirect2") as server_req2:
             with server.expect_request("/simple.json") as server_req3:
-                request.get(f"{server.PREFIX}/a/redirect1"),
+                request.get(f"{server.PREFIX}/a/redirect1")
     assert server_req1.value.getHeader("my-secret") == "Value"
     assert server_req2.value.getHeader("my-secret") == "Value"
     assert server_req3.value.getHeader("my-secret") == "Value"
@@ -142,7 +142,7 @@ def test_should_use_playwright_as_a_user_agent(
 ) -> None:
     request = playwright.request.new_context()
     with server.expect_request("/empty.html") as server_req:
-        request.get(server.EMPTY_PAGE),
+        request.get(server.EMPTY_PAGE)
     assert str(server_req.value.getHeader("User-Agent")).startswith("Playwright/")
     request.dispose()
 
diff --git a/tests/sync/test_locators.py b/tests/sync/test_locators.py
@@ -320,7 +320,7 @@ def test_locators_should_upload_a_file(page: Page, server: Server) -> None:
 def test_locators_should_press(page: Page) -> None:
     page.set_content("<input type='text' />")
     page.locator("input").press("h")
-    page.eval_on_selector("input", "input => input.value") == "h"
+    assert page.eval_on_selector("input", "input => input.value") == "h"
 
 
 def test_locators_should_scroll_into_view(page: Page, server: Server) -> None:
@@ -356,7 +356,7 @@ def test_locators_should_select_textarea(
 def test_locators_should_type(page: Page) -> None:
     page.set_content("<input type='text' />")
     page.locator("input").type("hello")
-    page.eval_on_selector("input", "input => input.value") == "hello"
+    assert page.eval_on_selector("input", "input => input.value") == "hello"
 
 
 def test_locators_should_screenshot(
diff --git a/tests/sync/test_page_request_fallback.py b/tests/sync/test_page_request_fallback.py
@@ -270,7 +270,7 @@ def test_should_amend_post_data(page: Page, server: Server) -> None:
     page.route("**/*", lambda route: route.fallback(post_data="doggo"))
 
     with server.expect_request("/sleep.zzz") as server_request_info:
-        page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })"),
+        page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })")
     server_request = server_request_info.value
     assert post_data == ["doggo"]
     assert server_request.post_body == b"doggo"
diff --git a/tests/sync/test_sync.py b/tests/sync/test_sync.py
@@ -190,7 +190,7 @@ def test_sync_network_events(page: Page, server: Server) -> None:
 def test_console_should_work(page: Page, browser_name: str) -> None:
     messages = []
     page.once("console", lambda m: messages.append(m))
-    page.evaluate('() => console.log("hello", 5, {foo: "bar"})'),
+    page.evaluate('() => console.log("hello", 5, {foo: "bar"})')
     assert len(messages) == 1
     message = messages[0]
     if browser_name != "firefox":
diff --git a/tests/sync/test_video.py b/tests/sync/test_video.py
@@ -105,6 +105,7 @@ def test_should_error_if_page_not_closed_before_save_as(
         video = page.video
         assert video
         video.save_as(out_path)
+    assert video
     assert "Page is not yet closed. Close the page prior to calling save_as" in str(err)
     assert not os.path.exists(out_path)
     page.context.close()

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ async def test_page_route_should_work_when_POST_is_redirected_with_302(page, ser`
`103`	`103`	`"""`
`104`	`104`	`)`
`105`	`105`	`async with page.expect_navigation():`
`106`		`- await page.eval_on_selector("form", "form => form.submit()"),`
	`106`	`+ await page.eval_on_selector("form", "form => form.submit()")`
`107`	`107`
`108`	`108`
`109`	`109`	`# @see https://github.com/GoogleChrome/puppeteer/issues/3973`