Skip to content

Commit ed4dcfb

Browse files
chore: remove redundant greenlet for tests (#1045)
1 parent d23d47a commit ed4dcfb

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

playwright/sync_api/_context_manager.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@
2525
from playwright._impl._transport import PipeTransport
2626
from playwright.sync_api._generated import Playwright as SyncPlaywright
2727

28-
# Used for sync API tests
29-
dispatcher_fiber: Any = None
30-
3128

3229
class PlaywrightContextManager:
3330
def __init__(self) -> None:
@@ -54,7 +51,6 @@ def greenlet_main() -> None:
5451
loop.run_until_complete(loop.shutdown_asyncgens())
5552
loop.close()
5653

57-
global dispatcher_fiber
5854
dispatcher_fiber = greenlet(greenlet_main)
5955
self._connection = Connection(
6056
dispatcher_fiber,

tests/server.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@
2525
from urllib.parse import urlparse
2626

2727
from autobahn.twisted.websocket import WebSocketServerFactory, WebSocketServerProtocol
28-
from greenlet import greenlet
2928
from OpenSSL import crypto
3029
from twisted.internet import reactor, ssl
3130
from twisted.internet.protocol import ClientFactory
3231
from twisted.web import http
3332

3433
from playwright._impl._path_utils import get_file_dirname
35-
from playwright.sync_api._context_manager import dispatcher_fiber
3634

3735
_dirname = get_file_dirname()
3836

@@ -164,17 +162,13 @@ def expect_request(
164162
) -> Generator[ExpectResponse[http.Request], None, None]:
165163
future = asyncio.create_task(self.wait_for_request(path))
166164

167-
g_self = greenlet.getcurrent()
168165
cb_wrapper: ExpectResponse[http.Request] = ExpectResponse()
169166

170167
def done_cb(task: asyncio.Task) -> None:
171168
cb_wrapper._value = future.result()
172-
g_self.switch()
173169

174170
future.add_done_callback(done_cb)
175171
yield cb_wrapper
176-
while not future.done():
177-
dispatcher_fiber.switch()
178172

179173
def set_auth(self, path: str, username: str, password: str) -> None:
180174
self.auth[path] = (username, password)

0 commit comments

Comments
 (0)