cherry-pick(#1567): chore: mark pathAfterFinished return value optional (#1569)

rwoll · web-flow · commit e0bfe51f86d3 · 2022-09-27T18:57:15.000-04:00
diff --git a/playwright/_impl/_artifact.py b/playwright/_impl/_artifact.py
@@ -33,7 +33,8 @@ async def path_after_finished(self) -> Optional[pathlib.Path]:
             raise Error(
                 "Path is not available when using browser_type.connect(). Use save_as() to save a local copy."
             )
-        return pathlib.Path(await self._channel.send("pathAfterFinished"))
+        path = await self._channel.send("pathAfterFinished")
+        return pathlib.Path(path) if path else None
 
     async def save_as(self, path: Union[str, Path]) -> None:
         stream = cast(Stream, from_channel(await self._channel.send("saveAsStream")))

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,8 @@ async def path_after_finished(self) -> Optional[pathlib.Path]:`
`33`	`33`	`raise Error(`
`34`	`34`	`"Path is not available when using browser_type.connect(). Use save_as() to save a local copy."`
`35`	`35`	`)`
`36`		`- return pathlib.Path(await self._channel.send("pathAfterFinished"))`
	`36`	`+ path = await self._channel.send("pathAfterFinished")`
	`37`	`+ return pathlib.Path(path) if path else None`
`37`	`38`
`38`	`39`	`async def save_as(self, path: Union[str, Path]) -> None:`
`39`	`40`	`stream = cast(Stream, from_channel(await self._channel.send("saveAsStream")))`