chore: do not crash when a crash emit was emitted (#1249)

mxschmitt · web-flow · commit d55a7ed0acd0 · 2022-04-11T19:30:38.000+02:00
diff --git a/playwright/_impl/_page.py b/playwright/_impl/_page.py
@@ -210,10 +210,16 @@ def __init__(
         )
         self._closed_or_crashed_future: asyncio.Future = asyncio.Future()
         self.on(
-            Page.Events.Close, lambda _: self._closed_or_crashed_future.set_result(True)
+            Page.Events.Close,
+            lambda _: self._closed_or_crashed_future.set_result(True)
+            if not self._closed_or_crashed_future.done()
+            else None,
         )
         self.on(
-            Page.Events.Crash, lambda _: self._closed_or_crashed_future.set_result(True)
+            Page.Events.Crash,
+            lambda _: self._closed_or_crashed_future.set_result(True)
+            if not self._closed_or_crashed_future.done()
+            else None,
         )
 
     def __repr__(self) -> str:

Original file line number	Diff line number	Diff line change
`@@ -210,10 +210,16 @@ def __init__(`
`210`	`210`	`)`
`211`	`211`	`self._closed_or_crashed_future: asyncio.Future = asyncio.Future()`
`212`	`212`	`self.on(`
`213`		`- Page.Events.Close, lambda _: self._closed_or_crashed_future.set_result(True)`
	`213`	`+ Page.Events.Close,`
	`214`	`+ lambda _: self._closed_or_crashed_future.set_result(True)`
	`215`	`+ if not self._closed_or_crashed_future.done()`
	`216`	`+ else None,`
`214`	`217`	`)`
`215`	`218`	`self.on(`
`216`		`- Page.Events.Crash, lambda _: self._closed_or_crashed_future.set_result(True)`
	`219`	`+ Page.Events.Crash,`
	`220`	`+ lambda _: self._closed_or_crashed_future.set_result(True)`
	`221`	`+ if not self._closed_or_crashed_future.done()`
	`222`	`+ else None,`
`217`	`223`	`)`
`218`	`224`
`219`	`225`	`def __repr__(self) -> str:`