chore: better type validation (#112)

Co-authored-by: Max Schmitt <max@schmitt.mx>

Author: pavelfeldman

.pre-commit-config.yaml

@@ -8,7 +8,6 @@ repos:
     -   id: end-of-file-fixer
         exclude: ^playwright/drivers/browsers.json$
     -   id: check-yaml
-    -   id: check-added-large-files
 -   repo: https://github.com/psf/black
     rev: 19.10b0
     hooks:

api.json

@@ -13,7 +13,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "playwright": "1.2.0-next.1596080705875"
+    "playwright": "1.2.0-next.1596151449209"
   },
   "devDependencies": {
     "pkg": "^4.4.9"

driver/package.json

@@ -16,6 +16,7 @@
 
 from playwright.connection import Channel
 from playwright.element_handle import ElementHandle
+from playwright.helper import locals_to_params
 
 
 def _ax_node_from_protocol(axNode: Dict[str, Any]) -> Dict[str, Any]:
@@ -58,10 +59,10 @@ def __init__(self, channel: Channel) -> None:
         self._loop = channel._connection._loop
 
     async def snapshot(
-        self, interestingOnly: bool = True, root: ElementHandle = None
+        self, interestingOnly: bool = None, root: ElementHandle = None
     ) -> Optional[Dict[str, Any]]:
-        params = {"interestingOnly": interestingOnly}
+        params = locals_to_params(locals())
         if root:
             params["root"] = root._channel
-        result = await self._channel.send("accessibilitySnapshot", params,)
+        result = await self._channel.send("accessibilitySnapshot", params)
         return _ax_node_from_protocol(result) if result else None