test: re-enable type checking on sync tests (#906)

Author: mxschmitt

playwright/_impl/_browser_context.py

@@ -135,7 +135,9 @@ def __init__(
             ),
         )
         self._closed_future: asyncio.Future = asyncio.Future()
-        self.once(self.Events.Close, lambda: self._closed_future.set_result(True))
+        self.once(
+            self.Events.Close, lambda context: self._closed_future.set_result(True)
+        )
 
     def __repr__(self) -> str:
         return f"<BrowserContext browser={self.browser}>"
@@ -292,7 +294,7 @@ def _on_close(self) -> None:
         if self._browser:
             self._browser._contexts.remove(self)
 
-        self.emit(BrowserContext.Events.Close)
+        self.emit(BrowserContext.Events.Close, self)
 
     async def close(self) -> None:
         try:

playwright/_impl/_network.py

@@ -417,7 +417,7 @@ def is_closed(self) -> bool:
 
     def _on_close(self) -> None:
         self._is_closed = True
-        self.emit(WebSocket.Events.Close)
+        self.emit(WebSocket.Events.Close, self)
 
 
 def serialize_headers(headers: Dict[str, str]) -> List[Header]:

playwright/_impl/_page.py

@@ -154,7 +154,7 @@ def __init__(
         self._channel.on("crash", lambda _: self._on_crash())
         self._channel.on("dialog", lambda params: self._on_dialog(params))
         self._channel.on(
-            "domcontentloaded", lambda _: self.emit(Page.Events.DOMContentLoaded)
+            "domcontentloaded", lambda _: self.emit(Page.Events.DOMContentLoaded, self)
         )
         self._channel.on("download", lambda params: self._on_download(params))
         self._channel.on(
@@ -174,7 +174,7 @@ def __init__(
             "frameDetached",
             lambda params: self._on_frame_detached(from_channel(params["frame"])),
         )
-        self._channel.on("load", lambda _: self.emit(Page.Events.Load))
+        self._channel.on("load", lambda _: self.emit(Page.Events.Load, self))
         self._channel.on(
             "pageError",
             lambda params: self.emit(
@@ -237,10 +237,10 @@ def _on_close(self) -> None:
             self._browser_context._pages.remove(self)
         if self in self._browser_context._background_pages:
             self._browser_context._background_pages.remove(self)
-        self.emit(Page.Events.Close)
+        self.emit(Page.Events.Close, self)
 
     def _on_crash(self) -> None:
-        self.emit(Page.Events.Crash)
+        self.emit(Page.Events.Crash, self)
 
     def _on_dialog(self, params: Any) -> None:
         dialog = cast(Dialog, from_channel(params["dialog"]))

playwright/_impl/_video.py

@@ -35,7 +35,7 @@ def __init__(self, page: "Page") -> None:
         if page.is_closed():
             self._page_closed()
         else:
-            page.on("close", lambda: self._page_closed())
+            page.on("close", lambda page: self._page_closed())
 
     def __repr__(self) -> str:
         return f"<Video page={self._page}>"

setup.cfg

@@ -14,7 +14,7 @@ warn_redundant_casts = True
 warn_unused_configs = True
 check_untyped_defs = True
 disallow_untyped_defs = True
-[mypy-tests.*]
+[mypy-tests/async.*]
 ignore_errors = True
 [flake8]
 ignore =

tests/sync/test_browsertype_connect.py

@@ -90,8 +90,8 @@ def test_browser_type_connect_disconnected_event_should_be_emitted_when_browser_
 
     disconnected1 = []
     disconnected2 = []
-    browser1.on("disconnected", lambda: disconnected1.append(True))
-    browser2.on("disconnected", lambda: disconnected2.append(True))
+    browser1.on("disconnected", lambda browser: disconnected1.append(True))
+    browser2.on("disconnected", lambda browser: disconnected2.append(True))
 
     page2 = browser2.new_page()
 
@@ -155,9 +155,9 @@ def test_browser_type_connect_should_forward_close_events_to_pages(
     page = context.new_page()
 
     events = []
-    browser.on("disconnected", lambda: events.append("browser::disconnected"))
-    context.on("close", lambda: events.append("context::close"))
-    page.on("close", lambda: events.append("page::close"))
+    browser.on("disconnected", lambda browser: events.append("browser::disconnected"))
+    context.on("close", lambda context: events.append("context::close"))
+    page.on("close", lambda page: events.append("page::close"))
 
     browser.close()
     assert events == ["page::close", "context::close", "browser::disconnected"]
@@ -176,9 +176,9 @@ def test_browser_type_connect_should_forward_close_events_on_remote_kill(
     page = context.new_page()
 
     events = []
-    browser.on("disconnected", lambda: events.append("browser::disconnected"))
-    context.on("close", lambda: events.append("context::close"))
-    page.on("close", lambda: events.append("page::close"))
+    browser.on("disconnected", lambda context: events.append("browser::disconnected"))
+    context.on("close", lambda context: events.append("context::close"))
+    page.on("close", lambda page: events.append("page::close"))
     remote.kill()
     with pytest.raises(Error):
         page.title()