Skip to content

Commit 5f9d5dd

Browse files
authored
test: skip broken FF nav test (#1404)
1 parent eb239a8 commit 5f9d5dd

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

tests/async/test_har.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from pathlib import Path
2121

2222
import pytest
23-
from flaky import flaky
2423

2524
from playwright.async_api import Browser, BrowserContext, Error, Page, Route, expect
2625
from tests.server import Server
@@ -437,7 +436,9 @@ async def test_should_go_back_to_redirected_navigation(
437436
assert await page.evaluate("window.location.href") == "https://www.theverge.com/"
438437

439438

440-
@flaky(max_runs=5) # Flaky upstream
439+
@pytest.mark.skip_browser(
440+
"firefox"
441+
) # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214)
441442
async def test_should_go_forward_to_redirected_navigation(
442443
context: BrowserContext, server: Server, assetdir: Path
443444
) -> None:

tests/sync/test_har.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from typing import Any, cast
2121

2222
import pytest
23-
from flaky import flaky
2423

2524
from playwright.sync_api import Browser, BrowserContext, Error, Page, Route, expect
2625
from tests.server import Server
@@ -374,7 +373,9 @@ def test_should_go_back_to_redirected_navigation(
374373
assert page.evaluate("window.location.href") == "https://www.theverge.com/"
375374

376375

377-
@flaky(max_runs=5) # Flaky upstream
376+
@pytest.mark.skip_browser(
377+
"firefox"
378+
) # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214)
378379
def test_should_go_forward_to_redirected_navigation(
379380
context: BrowserContext, server: Server, assetdir: Path
380381
) -> None:

0 commit comments

Comments
 (0)