Skip to content

Commit 516bdad

Browse files
authored
Revert "feat: make TimeoutError extend builtins.TimeoutError (#2297)" (#2312)
This reverts commit 8cd06e5.
1 parent 9625376 commit 516bdad

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,3 @@ coverage.xml
1818
junit/
1919
htmldocs/
2020
utils/docker/dist/
21-
.venv/
22-
Pipfile*

playwright/_impl/_errors.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
# stable API.
1717

1818

19-
from builtins import TimeoutError as TimeoutErrorBuiltin
2019
from typing import Optional
2120

2221

@@ -44,7 +43,7 @@ def stack(self) -> Optional[str]:
4443
return self._stack
4544

4645

47-
class TimeoutError(Error, TimeoutErrorBuiltin):
46+
class TimeoutError(Error):
4847
pass
4948

5049

tests/async/test_click.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414

1515
import asyncio
16-
import builtins
1716
from typing import Optional
1817

1918
import pytest
@@ -639,9 +638,6 @@ async def test_timeout_waiting_for_hit_target(page: Page, server: Server) -> Non
639638
assert "Timeout 5000ms exceeded." in error.message
640639
assert '<div id="blocker"></div> intercepts pointer events' in error.message
641640
assert "retrying click action" in error.message
642-
assert isinstance(error, Error)
643-
assert isinstance(error, TimeoutError)
644-
assert isinstance(error, builtins.TimeoutError)
645641

646642

647643
async def test_fail_when_obscured_and_not_waiting_for_hit_target(

0 commit comments

Comments
 (0)