Repo: Move more allows to expects (#1654)

smalis-msft · web-flow · commit a3f6faf00502 · 2025-07-15T13:32:43.000-07:00
Let's see how many of these fail CI. Progress on #300.
diff --git a/Guide/src/dev_guide/contrib/code.md b/Guide/src/dev_guide/contrib/code.md
@@ -142,7 +142,7 @@ project, and will fast-fail if it catches any warnings / errors.
 ### Suppressing Lints
 
 In general, lints should be fixed by modifying the code to satisfy the lint.
-However, there are cases where a lint may need to be `allow`'d inline.
+However, there are cases where a lint may need to be `expect`'d inline.
 
 In these cases, you _must_ provide a inline comment providing reasonable
 justification for the suppressed lint.
@@ -152,7 +152,7 @@ e.g:
 ```rust
 // x86_64-unknown-linux-musl targets have a different type defn for
 // `libc::cmsghdr`, hence why these lints are being suppressed.
-#[allow(clippy::needless_update, clippy::useless_conversion)]
+#[expect(clippy::needless_update, clippy::useless_conversion)]
 libc::cmsghdr {
     cmsg_level: libc::SOL_SOCKET,
     cmsg_type: libc::SCM_RIGHTS,
diff --git a/openvmm/openvmm_entry/src/cli_args.rs b/openvmm/openvmm_entry/src/cli_args.rs
@@ -1590,8 +1590,11 @@ mod tests {
         assert!(DiskCliKind::from_str("sqldiff:path").is_err());
 
         // Missing OPENVMM_AUTO_CACHE_PATH for AutoCacheSqlite
-        #[allow(deprecated_safe_2024)]
-        std::env::remove_var("OPENVMM_AUTO_CACHE_PATH");
+        // SAFETY:
+        // Safe in a testing context because it won't be changed concurrently
+        unsafe {
+            std::env::remove_var("OPENVMM_AUTO_CACHE_PATH");
+        }
         assert!(DiskCliKind::from_str("autocache:key:file:disk.vhd").is_err());
 
         // Invalid blob kind
diff --git a/support/mesh/src/lib.rs b/support/mesh/src/lib.rs
@@ -8,7 +8,7 @@
 #![expect(missing_docs)]
 #![forbid(unsafe_code)]
 
-#[allow(unused_extern_crates)]
+#[expect(unused_extern_crates)]
 extern crate self as mesh;
 
 pub mod payload {
diff --git a/support/pal/src/windows/alpc.rs b/support/pal/src/windows/alpc.rs
@@ -21,7 +21,7 @@ use std::time::Duration;
 use winapi::shared::ntstatus::STATUS_TIMEOUT;
 
 mod ntlpcapi {
-    #![allow(non_snake_case, dead_code, clippy::upper_case_acronyms)]
+    #![expect(non_snake_case, dead_code)]
 
     pub use ntapi::ntlpcapi::*;
     use winapi::shared::ntdef::HANDLE;
diff --git a/tmk/simple_tmk/src/main.rs b/tmk/simple_tmk/src/main.rs
@@ -5,7 +5,7 @@
 
 #![cfg_attr(minimal_rt, no_std, no_main)]
 // UNSAFETY: TMK tests are going to need to perform unsafe operations.
-#![allow(unsafe_code)]
+#![cfg_attr(target_arch = "x86_64", expect(unsafe_code))]
 
 mod prelude;
 
diff --git a/tmk/simple_tmk/src/prelude.rs b/tmk/simple_tmk/src/prelude.rs
@@ -8,7 +8,7 @@
 //! use crate::prelude::*;
 //! ```
 
-#![allow(unused_imports)]
+#![cfg_attr(target_arch = "aarch64", expect(unused_imports))]
 
 pub use tmk_core::Scope;
 pub use tmk_core::TestContext;
diff --git a/vm/acpi_spec/src/lib.rs b/vm/acpi_spec/src/lib.rs
@@ -16,7 +16,7 @@ pub mod madt;
 pub mod pptt;
 pub mod srat;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 mod packed_nums {
     pub type u16_ne = zerocopy::U16<zerocopy::NativeEndian>;
     pub type u32_ne = zerocopy::U32<zerocopy::NativeEndian>;
diff --git a/vm/devices/firmware/uefi_specs/src/hyperv/crypto.rs b/vm/devices/firmware/uefi_specs/src/hyperv/crypto.rs
@@ -11,7 +11,7 @@ use zerocopy::Immutable;
 use zerocopy::IntoBytes;
 use zerocopy::KnownLayout;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 mod packed_nums {
     pub type u64_ne = zerocopy::U64<zerocopy::NativeEndian>;
 }
diff --git a/vm/devices/firmware/uefi_specs/src/hyperv/nvram.rs b/vm/devices/firmware/uefi_specs/src/hyperv/nvram.rs
@@ -13,7 +13,7 @@ use zerocopy::Immutable;
 use zerocopy::IntoBytes;
 use zerocopy::KnownLayout;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 mod packed_nums {
     pub type u64_ne = zerocopy::U64<zerocopy::NativeEndian>;
 }
diff --git a/vm/devices/hyperv_ic_protocol/src/kvp.rs b/vm/devices/hyperv_ic_protocol/src/kvp.rs
@@ -56,7 +56,7 @@ open_enum! {
     /// The pool to use for a value.
     #[derive(IntoBytes, Immutable, KnownLayout, FromBytes)]
     pub enum KvpPool: u8 {
-        #![allow(missing_docs)] // TODO: figure out what the semantics of these actually are.
+        #![expect(missing_docs)] // TODO: figure out what the semantics of these actually are.
         EXTERNAL = 0,
         GUEST = 1,
         AUTO = 2,
diff --git a/vm/devices/hyperv_ic_protocol/src/vss.rs b/vm/devices/hyperv_ic_protocol/src/vss.rs
@@ -3,7 +3,7 @@
 
 //! Protocol definitions for the VSS (Volume Shadow Service) IC.
 
-#![allow(missing_docs)]
+#![expect(missing_docs)]
 
 use crate::Version;
 use guid::Guid;
diff --git a/vm/devices/net/linux_net_bindings/src/lib.rs b/vm/devices/net/linux_net_bindings/src/lib.rs
@@ -16,8 +16,8 @@ use std::os::raw::c_int;
 // Generated using:
 //
 // bindgen --no-layout-tests --with-derive-default --wrap-unsafe-ops --no-doc-comments /usr/include/linux/if.h
-#[allow(non_camel_case_types)]
-#[allow(non_upper_case_globals)]
+#[expect(non_camel_case_types)]
+#[expect(non_upper_case_globals)]
 #[expect(clippy::missing_safety_doc)]
 #[expect(clippy::undocumented_unsafe_blocks)]
 #[expect(clippy::ref_as_ptr)]
@@ -27,8 +27,7 @@ pub mod gen_if;
 // Generated using:
 //
 // bindgen --no-layout-tests --with-derive-default --wrap-unsafe-ops --no-doc-comments /usr/include/linux/if_tun.h
-#[allow(non_camel_case_types)]
-#[allow(non_upper_case_globals)]
+#[expect(non_camel_case_types)]
 #[expect(clippy::missing_safety_doc)]
 #[expect(clippy::undocumented_unsafe_blocks)]
 #[expect(clippy::ref_as_ptr)]
diff --git a/vm/devices/storage/disk_vhdmp/src/lib.rs b/vm/devices/storage/disk_vhdmp/src/lib.rs
@@ -26,12 +26,7 @@ use vm_resource::declare_static_resolver;
 use vm_resource::kind::DiskHandleKind;
 
 mod virtdisk {
-    #![allow(
-        non_snake_case,
-        dead_code,
-        non_camel_case_types,
-        clippy::upper_case_acronyms
-    )]
+    #![expect(non_snake_case, dead_code)]
 
     use std::os::windows::prelude::*;
     use winapi::shared::guiddef::GUID;
diff --git a/vm/devices/storage/ide/src/protocol.rs b/vm/devices/storage/ide/src/protocol.rs
@@ -9,7 +9,7 @@ use zerocopy::Immutable;
 use zerocopy::IntoBytes;
 use zerocopy::KnownLayout;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 mod packed_nums {
     pub type u32_le = zerocopy::U32<zerocopy::LittleEndian>;
     pub type u64_le = zerocopy::U64<zerocopy::LittleEndian>;
diff --git a/vm/devices/storage/storvsc_driver/src/lib.rs b/vm/devices/storage/storvsc_driver/src/lib.rs
@@ -666,7 +666,7 @@ struct StorvscCompletionPacket {
 }
 
 #[derive(Debug)]
-#[allow(dead_code)]
+#[expect(dead_code)]
 struct StorvscDataPacket {
     transaction_id: Option<u64>,
     request_size: usize,
diff --git a/vm/devices/storage/storvsc_driver/src/test_helpers.rs b/vm/devices/storage/storvsc_driver/src/test_helpers.rs
@@ -4,7 +4,7 @@
 //! Helpers for unit tests.
 
 #![cfg_attr(not(test), expect(dead_code))]
-#![allow(missing_docs)]
+#![expect(missing_docs)]
 
 use crate::PacketError;
 use crate::Storvsc;
@@ -107,15 +107,13 @@ impl Version {
     }
 }
 
-#[allow(dead_code)]
 #[derive(Debug, Default, Clone)]
 struct Range {
     buf: MultiPagedRangeBuf<GpnList>,
     len: usize,
     is_write: bool,
 }
 
-#[allow(dead_code)]
 impl Range {
     fn new(
         buf: MultiPagedRangeBuf<GpnList>,
@@ -131,15 +129,16 @@ impl Range {
         Some(Self { buf, len, is_write })
     }
 
+    #[expect(dead_code)]
     fn buffer<'a>(&'a self, guest_memory: &'a GuestMemory) -> RequestBuffers<'a> {
         let mut range = self.buf.first().unwrap_or_else(PagedRange::empty);
         range.truncate(self.len);
         RequestBuffers::new(guest_memory, range, self.is_write)
     }
 }
 
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
+#[expect(dead_code)]
 pub(crate) struct ScsiRequestAndRange {
     external_data: Range,
     request: storvsp_protocol::ScsiRequest,
diff --git a/vm/devices/support/fs/fuse/src/protocol.rs b/vm/devices/support/fs/fuse/src/protocol.rs
@@ -7,7 +7,6 @@
 //! FUSE protocol version 7.31.
 //!
 //! For more details, see fuse.h.
-#![allow(non_snake_case)]
 #![allow(non_camel_case_types)]
 #![expect(unused_parens)]
 
diff --git a/vm/devices/support/fs/lx/src/lib.rs b/vm/devices/support/fs/lx/src/lib.rs
@@ -15,17 +15,17 @@ use thiserror::Error;
 pub use string::LxStr;
 pub use string::LxString;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 pub type uid_t = u32;
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 pub type gid_t = u32;
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 pub type mode_t = u32;
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 pub type ino_t = u64;
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 pub type off_t = i64;
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 pub type dev_t = usize;
 
 pub const MODE_INVALID: mode_t = mode_t::MAX;
diff --git a/vm/devices/support/fs/lxutil/src/windows/api.rs b/vm/devices/support/fs/lxutil/src/windows/api.rs
@@ -1,12 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-#![allow(
-    non_snake_case,
-    non_camel_case_types,
-    dead_code,
-    clippy::upper_case_acronyms
-)]
+#![expect(non_snake_case, dead_code)]
 
 use ntapi::ntioapi;
 use std::ffi;
@@ -37,7 +32,7 @@ pub const LX_UTIL_XATTR_LIST_CASE_SENSITIVE_DIR: ntdef::ULONG = 0x1;
 // Size of PE header signature.
 pub const LX_UTIL_PE_HEADER_SIZE: ntdef::ULONG = 2;
 
-#[allow(non_camel_case_types, non_snake_case)]
+#[expect(non_snake_case)]
 #[repr(C)]
 pub struct FILE_ID_64_EXTD_DIR_INFORMATION {
     pub NextEntryOffset: u32,
@@ -56,7 +51,7 @@ pub struct FILE_ID_64_EXTD_DIR_INFORMATION {
     pub FileName: [u16; 1],
 }
 
-#[allow(non_camel_case_types, non_snake_case)]
+#[expect(non_snake_case)]
 #[repr(C)]
 pub struct FILE_ID_ALL_EXTD_DIR_INFORMATION {
     pub NextEntryOffset: u32,
diff --git a/vm/devices/support/fs/lxutil/src/windows/mod.rs b/vm/devices/support/fs/lxutil/src/windows/mod.rs
@@ -939,7 +939,7 @@ impl LxVolume {
 
             /// Only the required header for FSCTL_SET_REPARSE_POINT, with data length of zero.
             /// See ntifs.h REPARSE_DATA_BUFFER.
-            #[allow(non_camel_case_types, non_snake_case)]
+            #[expect(non_snake_case)]
             #[repr(C)]
             #[derive(Clone, Copy, IntoBytes, Immutable, KnownLayout, FromBytes)]
             struct REPARSE_DATA_BUFFER {
diff --git a/vm/devices/support/fs/lxutil/src/windows/util.rs b/vm/devices/support/fs/lxutil/src/windows/util.rs
@@ -1053,7 +1053,7 @@ pub fn create_link(
 
     // This matches the public definition of FILE_LINK_INFORMATION in ntifs.h, with the variable length payload field
     // at the end removed. u8 arrays are used for fields to remove the need for padding and repr(packed).
-    #[allow(non_snake_case, non_camel_case_types)]
+    #[expect(non_snake_case)]
     #[repr(C)]
     #[derive(Debug, Clone, Copy, IntoBytes, Immutable, KnownLayout, FromBytes)]
     struct FILE_LINK_INFORMATION {
@@ -1170,7 +1170,6 @@ pub fn rename(
     //
     // TODO: Figure out a way of partially automating this process for Windows
     // structures, as a lot of this code is copied from create_link
-    #[allow(non_camel_case_types)]
     #[derive(Default, Clone, Copy)]
     #[repr(C)]
     struct FILE_RENAME_INFORMATION {
@@ -1182,7 +1181,7 @@ pub fn rename(
     }
 
     // Wrapper around FILE_RENAME_INFORMATION to allow compatibility with FileInformationClass trait
-    #[allow(non_camel_case_types)]
+    #[expect(non_camel_case_types)]
     #[derive(Default, Clone, Copy)]
     #[repr(transparent)]
     struct FILE_RENAME_INFORMATION_EX(FILE_RENAME_INFORMATION);
diff --git a/vm/devices/tpm/src/tpm20proto.rs b/vm/devices/tpm/src/tpm20proto.rs
@@ -15,7 +15,7 @@ use zerocopy::Immutable;
 use zerocopy::IntoBytes;
 use zerocopy::KnownLayout;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 mod packed_nums {
     pub type u16_be = zerocopy::U16<zerocopy::BigEndian>;
     pub type u32_be = zerocopy::U32<zerocopy::BigEndian>;
@@ -223,7 +223,7 @@ impl CommandCode {
     }
 }
 
-#[allow(non_camel_case_types, clippy::upper_case_acronyms)]
+#[expect(non_camel_case_types, clippy::upper_case_acronyms)]
 #[derive(Debug, Clone, Copy, PartialEq)]
 #[repr(u32)]
 pub enum CommandCodeEnum {
@@ -601,7 +601,7 @@ impl AlgId {
     }
 }
 
-#[allow(non_camel_case_types, clippy::upper_case_acronyms)]
+#[expect(clippy::upper_case_acronyms)]
 #[derive(Debug)]
 #[repr(u16)]
 pub enum AlgIdEnum {
diff --git a/vm/devices/virtio/virtio/src/spec.rs b/vm/devices/virtio/virtio/src/spec.rs
@@ -5,7 +5,7 @@
 
 pub use packed_nums::*;
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 mod packed_nums {
     pub type u16_le = zerocopy::U16<zerocopy::LittleEndian>;
     pub type u32_le = zerocopy::U32<zerocopy::LittleEndian>;
diff --git a/vm/devices/vmbus/vmbus_proxy/src/proxyioctl.rs b/vm/devices/vmbus/vmbus_proxy/src/proxyioctl.rs
@@ -1,12 +1,11 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-#![allow(
+#![expect(
     dead_code,
     non_snake_case,
     non_upper_case_globals,
-    non_camel_case_types,
-    clippy::upper_case_acronyms
+    non_camel_case_types
 )]
 
 use super::vmbusioctl::VMBUS_CHANNEL_OFFER;
diff --git a/vm/devices/vmbus/vmbus_proxy/src/vmbusioctl.rs b/vm/devices/vmbus/vmbus_proxy/src/vmbusioctl.rs
@@ -1,13 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-#![allow(
-    dead_code,
-    non_camel_case_types,
-    non_snake_case,
-    non_upper_case_globals,
-    clippy::upper_case_acronyms
-)]
+#![expect(non_snake_case)]
 
 use bitfield_struct::bitfield;
 use vmbus_core::protocol::UserDefinedData;
diff --git a/vm/hv1/hv1_hypercall/src/tests.rs b/vm/hv1/hv1_hypercall/src/tests.rs
@@ -336,7 +336,7 @@ struct TestController {
 open_enum! {
     #[derive(IntoBytes, Immutable, KnownLayout, FromBytes)]
     enum TestHypercallCode: u16 {
-        #![allow(non_upper_case_globals)]
+        #![expect(non_upper_case_globals)]
         CallSimpleNoOutput = 0x1001,
         CallSimple = 0x1002,
         CallRepNoOutput = 0x1003,
diff --git a/vm/loader/loader_defs/src/linux.rs b/vm/loader/loader_defs/src/linux.rs
@@ -7,6 +7,7 @@
 //! [`The Linux/x86 Boot Protocol`](https://www.kernel.org/doc/html/latest/x86/boot.html).
 
 #![expect(missing_docs)]
+#![expect(non_camel_case_types)]
 
 use static_assertions::const_assert_eq;
 use zerocopy::FromBytes;
@@ -15,7 +16,6 @@ use zerocopy::Immutable;
 use zerocopy::IntoBytes;
 use zerocopy::KnownLayout;
 
-#[allow(non_camel_case_types)]
 mod packed_nums {
     pub type u16_ne = zerocopy::U16<zerocopy::NativeEndian>;
     pub type u32_ne = zerocopy::U32<zerocopy::NativeEndian>;
diff --git a/vm/loader/page_table/src/aarch64.rs b/vm/loader/page_table/src/aarch64.rs
diff --git a/vm/loader/src/uefi/mod.rs b/vm/loader/src/uefi/mod.rs
diff --git a/vm/vbs_defs/src/lib.rs b/vm/vbs_defs/src/lib.rs
diff --git a/vm/vhd1_defs/src/lib.rs b/vm/vhd1_defs/src/lib.rs
diff --git a/vm/whp/src/abi.rs b/vm/whp/src/abi.rs
diff --git a/vm/whp/src/api.rs b/vm/whp/src/api.rs
diff --git a/workers/debug_worker/src/gdb/arch/x86/mod.rs b/workers/debug_worker/src/gdb/arch/x86/mod.rs
diff --git a/workers/vnc_worker/vnc/src/rfb.rs b/workers/vnc_worker/vnc/src/rfb.rs

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ use zerocopy::Immutable;`
`11`	`11`	`use zerocopy::IntoBytes;`
`12`	`12`	`use zerocopy::KnownLayout;`
`13`	`13`
`14`		`-#[allow(non_camel_case_types)]`
	`14`	`+#[expect(non_camel_case_types)]`
`15`	`15`	`mod packed_nums {`
`16`	`16`	`pub type u64_ne = zerocopy::U64<zerocopy::NativeEndian>;`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ use zerocopy::Immutable;`
`13`	`13`	`use zerocopy::IntoBytes;`
`14`	`14`	`use zerocopy::KnownLayout;`
`15`	`15`
`16`		`-#[allow(non_camel_case_types)]`
	`16`	`+#[expect(non_camel_case_types)]`
`17`	`17`	`mod packed_nums {`
`18`	`18`	`pub type u64_ne = zerocopy::U64<zerocopy::NativeEndian>;`
`19`	`19`	`}`