petri: use generics instead of Box for backends (#1669)

Refactors petri to use generics instead of Box for backends. This should
reduce duplicate code going forward and makes it possible to use
generics in backend-agnostic configuration functions.

Author: tjones60

flowey/flowey_hvlite/src/pipelines/vmm_tests.rs

@@ -45,7 +45,7 @@ pub struct VmmTestsCli {
     ///
     /// Available flags with default values:
     ///
-    /// `-tdx,-hyperv_vbs,+windows,+ubuntu,+freebsd,+openhcl,+openvmm,+hyperv,+uefi,+pcat,+tmk,+guest_test_uefi`
+    /// `-tdx,-hyperv_vbs,+windows,+ubuntu,+freebsd,+linux,+openhcl,+openvmm,+hyperv,+uefi,+pcat,+tmk,+guest_test_uefi`
     // TODO: Automatically generate the list of possible flags
     #[clap(long)]
     flags: Option<VmmTestSelectionFlags>,

flowey/flowey_lib_hvlite/src/_jobs/local_build_and_run_nextest_vmm_tests.rs

@@ -89,6 +89,7 @@ define_vmm_test_selection_flags! {
     windows: true,
     ubuntu: true,
     freebsd: true,
+    linux: true,
     openhcl: true,
     openvmm: true,
     hyperv: true,
@@ -215,6 +216,7 @@ impl SimpleFlowNode for Node {
                 windows,
                 mut ubuntu,
                 freebsd,
+                linux,
                 mut openhcl,
                 openvmm,
                 hyperv,
@@ -250,7 +252,6 @@ impl SimpleFlowNode for Node {
                 }
                 if !ubuntu {
                     filter.push_str(" & !test(ubuntu)");
-                    build.pipette_linux = false;
                 }
                 if !windows {
                     filter.push_str(" & !test(windows)");
@@ -259,6 +260,12 @@ impl SimpleFlowNode for Node {
                 if !freebsd {
                     filter.push_str(" & !test(freebsd)");
                 }
+                if !linux {
+                    filter.push_str(" & !test(linux)");
+                }
+                if !linux && !ubuntu {
+                    build.pipette_linux = false;
+                }
                 if !openhcl {
                     filter.push_str(" & !test(openhcl)");
                     build.openhcl = false;
@@ -297,13 +304,13 @@ impl SimpleFlowNode for Node {
                         if ubuntu {
                             artifacts.push(KnownTestArtifacts::Ubuntu2204ServerX64Vhd);
                         }
-                        if windows {
-                            artifacts.extend_from_slice(&[
-                                KnownTestArtifacts::Gen1WindowsDataCenterCore2022X64Vhd,
-                                KnownTestArtifacts::Gen2WindowsDataCenterCore2022X64Vhd,
-                            ]);
+                        if windows && uefi {
+                            artifacts.push(KnownTestArtifacts::Gen2WindowsDataCenterCore2022X64Vhd);
+                        }
+                        if windows && pcat {
+                            artifacts.push(KnownTestArtifacts::Gen1WindowsDataCenterCore2022X64Vhd);
                         }
-                        if freebsd {
+                        if freebsd && pcat {
                             artifacts.extend_from_slice(&[
                                 KnownTestArtifacts::FreeBsd13_2X64Vhd,
                                 KnownTestArtifacts::FreeBsd13_2X64Iso,

openvmm/openvmm_entry/src/lib.rs

@@ -974,7 +974,7 @@ fn vm_config_from_command_line(
                             get_resources::ged::GuestSecureBootTemplateType::MicrosoftWindows
                         },
                         Some(SecureBootTemplateCli::UefiCa) => {
-                            get_resources::ged::GuestSecureBootTemplateType::MicrosoftUefiCertificateAuthoritiy
+                            get_resources::ged::GuestSecureBootTemplateType::MicrosoftUefiCertificateAuthority
                         }
                         None => {
                             get_resources::ged::GuestSecureBootTemplateType::None

petri/src/lib.rs

@@ -10,7 +10,10 @@
 
 pub mod disk_image;
 mod linux_direct_serial_agent;
-mod openhcl_diag;
+// TODO: Add docs and maybe a trait interface for this, or maybe this can
+// remain crate-local somehow without violating interface privacy.
+#[expect(missing_docs)]
+pub mod openhcl_diag;
 mod test;
 mod tracing;
 mod vm;

petri/src/openhcl_diag.rs

@@ -8,12 +8,11 @@ use diag_client::kmsg_stream::KmsgStream;
 use futures::io::AllowStdIo;
 use std::io::Read;
 
-pub(crate) struct OpenHclDiagHandler(DiagClient);
+pub struct OpenHclDiagHandler(DiagClient);
 
 /// The result of running a VTL2 command.
 #[derive(Debug)]
-#[expect(dead_code)] // Fields output via Debug for debugging purposes.
-pub(crate) struct Vtl2CommandResult {
+pub struct Vtl2CommandResult {
     /// The stdout of the command.
     pub stdout: String,
     /// The stderr of the command.
@@ -74,7 +73,7 @@ impl OpenHclDiagHandler {
         })
     }
 
-    pub(crate) async fn core_dump(&self, name: &str, path: &std::path::Path) -> anyhow::Result<()> {
+    pub async fn core_dump(&self, name: &str, path: &std::path::Path) -> anyhow::Result<()> {
         let client = self.diag_client().await?;
         let pid = client.get_pid(name).await?;
         client
@@ -87,21 +86,21 @@ impl OpenHclDiagHandler {
             .await
     }
 
-    pub(crate) async fn crash(&self, name: &str) -> anyhow::Result<()> {
+    pub async fn crash(&self, name: &str) -> anyhow::Result<()> {
         let client = self.diag_client().await?;
         let pid = client.get_pid(name).await?;
         client.crash(pid).await
     }
 
-    pub(crate) async fn test_inspect(&self) -> anyhow::Result<()> {
+    pub async fn test_inspect(&self) -> anyhow::Result<()> {
         self.diag_client()
             .await?
             .inspect("", None, None)
             .await
             .map(|_| ())
     }
 
-    pub(crate) async fn kmsg(&self) -> anyhow::Result<KmsgStream> {
+    pub async fn kmsg(&self) -> anyhow::Result<KmsgStream> {
         self.diag_client().await?.kmsg(false).await
     }