fix: suggestion appears and hangs after enter (#236)

cpendery · web-flow · commit b5c060c6189f · 2024-04-14T16:25:55.000-07:00
Signed-off-by: Chapman Pendery &lt;cpendery@vt.edu&gt;
diff --git a/src/ui/suggestionManager.ts b/src/ui/suggestionManager.ts
@@ -161,6 +161,9 @@ export class SuggestionManager {
 
   update(keyPress: KeyPress): boolean {
     const { name, shift, ctrl } = keyPress;
+    if (name == "return") {
+      this.#term.clearCommand(); // clear the current command on enter
+    }
     if (!this.#suggestBlob) {
       return false;
     }
@@ -186,9 +189,6 @@ export class SuggestionManager {
       }
       this.#term.write(removals + chars);
     } else {
-      if (name == "return") {
-        this.#term.clearCommand(); // clear the current command on enter
-      }
       return false;
     }
     log.debug({ msg: "handled keypress", ...keyPress });

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,9 @@ export class SuggestionManager {`
`161`	`161`
`162`	`162`	`update(keyPress: KeyPress): boolean {`
`163`	`163`	`const { name, shift, ctrl } = keyPress;`
	`164`	`+ if (name == "return") {`
	`165`	`+ this.#term.clearCommand(); // clear the current command on enter`
	`166`	`+ }`
`164`	`167`	`if (!this.#suggestBlob) {`
`165`	`168`	`return false;`
`166`	`169`	`}`
`@@ -186,9 +189,6 @@ export class SuggestionManager {`
`186`	`189`	`}`
`187`	`190`	`this.#term.write(removals + chars);`
`188`	`191`	`} else {`
`189`		`- if (name == "return") {`
`190`		`- this.#term.clearCommand(); // clear the current command on enter`
`191`		`- }`
`192`	`192`	`return false;`
`193`	`193`	`}`
`194`	`194`	`log.debug({ msg: "handled keypress", ...keyPress });`