Fix attach to process on arm64 Mac. #1917
Conversation
…4 mac. The primary issue was that we weren't building the attach.dylib for all targets; but even once we did that we had to ensure that we were exiting successfully after injecting into the process. We pulled in the compile changes from JetBrains/intellij-community@2e7109f Co-authored-by: @artemmukhin <Artem.Mukhin@jetbrains.com> Co-authored-by: Cole Miller <cole@zed.dev>
ConradIrwin
force-pushed
the
arm64-mac-attach
branch
from
4e2182d to
ba0bbba
Compare
|
@microsoft-github-policy-service agree company="Zed Industries" |
| #!/bin/bash | ||
| set -euxo pipefail | ||
|
|
||
| clang++ -fPIC -D_REENTRANT -std=c++11 -arch arm64 -c -o attach_arm64.o attach.cpp |
There was a problem hiding this comment.
I assume clang supports D_FORTIFY_SOURCE?. We have internal requirements on this flag being set or Microsoft security won't let us ship this binary. Can you try adding it back?
There was a problem hiding this comment.
And why use clang instead of g++? Could you continue to use g++ to create the other arch, and then just add the lipo command?
There was a problem hiding this comment.
SRC to attach.cpp is off. Should likely be this: $SRC/linux_and_mac/attach.cpp. I believe that's what is causing the build failure in the pipeline.
There was a problem hiding this comment.
The build script was pulled from JetBrains/intellij-community@2e7109f. I've pushed up a new version that is more like the original.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the submission :). Should ship in our next release. Sometime before 3.14 goes GA I think. |
|
Great, thank you for the super fast turnaround. |
Before this change it was not possible to attach to a process on arm64 mac.
The primary issue was that we weren't building the attach.dylib for all targets; but even once we did that we had to ensure that we were exiting successfully after injecting into the process.
We pulled in the compile changes from JetBrains/intellij-community@2e7109f
Co-authored-by: @artemmukhin Artem.Mukhin@jetbrains.com
Co-authored-by: Cole Miller cole@zed.dev