Fix test failures #1621
Merged
Fix test failures #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Jul 8, 2024
|
The windows py312 failing tests seem to be sporadic and they don't repro locally. So I'm marking this test as flaky with a retry to see if it gets past the error. The only downside is I had to remove python 3.8 from the test suite, BUT I'm ok with this considering 3.8 loses all official support in about 3 months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirements.txt used by the unit tests doesn't specify explicit versions for the dependencies. A recent numpy release has broken our tests because of this, since the tests always use the latest release.
The two options for fixing this are:
I opted for the latter solution. 😄