Merge pull request #87 from fcojavmc/fix-coredump

wravery · web-flow · commit f77f95bea220 · 2020-01-25T13:37:16.000-08:00
BUG: Instrospection query with non-valid type name crashes
diff --git a/src/Introspection.cpp b/src/Introspection.cpp
@@ -32,6 +32,11 @@ void Schema::AddType(response::StringType&& name, std::shared_ptr<object::Type>
 
 const std::shared_ptr<object::Type>& Schema::LookupType(const response::StringType& name) const
 {
+	if (_typeMap.find(name) == _typeMap.cend())
+	{
+		throw service::schema_exception { { "type not found" } };
+	}
+
 	return _types[_typeMap.find(name)->second].second;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,11 @@ void Schema::AddType(response::StringType&& name, std::shared_ptr<object::Type>`
`32`	`32`
`33`	`33`	`const std::shared_ptr<object::Type>& Schema::LookupType(const response::StringType& name) const`
`34`	`34`	`{`
	`35`	`+ if (_typeMap.find(name) == _typeMap.cend())`
	`36`	`+ {`
	`37`	`+ throw service::schema_exception { { "type not found" } };`
	`38`	`+ }`
	`39`	`+`
`35`	`40`	`return _types[_typeMap.find(name)->second].second;`
`36`	`41`	`}`
`37`	`42`