Skip to content

Commit e477ba7

Browse files
committed
Fix non-virtual destructors on base classes used with shared_ptr
1 parent 00fd98b commit e477ba7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

GraphQLService.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ class Object : public std::enable_shared_from_this<Object>
265265
{
266266
public:
267267
explicit Object(TypeNames&& typeNames, ResolverMap&& resolvers);
268+
virtual ~Object() = default;
268269

269270
rapidjson::Document resolve(const peg::ast_node& selection, const FragmentMap& fragments, const rapidjson::Value::ConstObject& variables) const;
270271

@@ -399,6 +400,7 @@ class Request : public std::enable_shared_from_this<Request>
399400
{
400401
public:
401402
explicit Request(TypeMap&& operationTypes);
403+
virtual ~Request() = default;
402404

403405
rapidjson::Document resolve(const peg::ast_node& root, const std::string& operationName, const rapidjson::Document::ConstObject& variables) const;
404406

0 commit comments

Comments
 (0)