add virtual dtor

yuval-k · yuval-k · commit c63f6cacd43d · 2021-04-29T11:46:55.000-04:00
diff --git a/include/graphqlservice/GraphQLSchema.h b/include/graphqlservice/GraphQLSchema.h
@@ -82,6 +82,8 @@ class Schema : public std::enable_shared_from_this<Schema>
 class BaseType : public std::enable_shared_from_this<BaseType>
 {
 public:
+	GRAPHQLSERVICE_EXPORT virtual ~BaseType() = default;
+
 	// Accessors
 	GRAPHQLSERVICE_EXPORT introspection::TypeKind kind() const noexcept;
 	GRAPHQLSERVICE_EXPORT virtual std::string_view name() const noexcept;

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,8 @@ class Schema : public std::enable_shared_from_this<Schema>`
`82`	`82`	`class BaseType : public std::enable_shared_from_this<BaseType>`
`83`	`83`	`{`
`84`	`84`	`public:`
	`85`	`+ GRAPHQLSERVICE_EXPORT virtual ~BaseType() = default;`
	`86`	`+`
`85`	`87`	`// Accessors`
`86`	`88`	`GRAPHQLSERVICE_EXPORT introspection::TypeKind kind() const noexcept;`
`87`	`89`	`GRAPHQLSERVICE_EXPORT virtual std::string_view name() const noexcept;`