Skip to content

Commit c500583

Browse files
committed
Always set CMAKE_RC_FLAGS for Windows
1 parent 9ef4c8d commit c500583

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

src/CMakeLists.txt

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ if(GRAPHQL_UPDATE_VERSION)
1717
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/../include/graphqlservice/internal/Version.h)
1818

1919
# res/target_version.rc
20-
set(CMAKE_RC_FLAGS "/nologo")
21-
set(CMAKE_RC_FLAGS_DEBUG "/dDEBUG")
2220
set(GRAPHQL_RC_VERSION "${PROJECT_VERSION_MAJOR},${PROJECT_VERSION_MINOR},${PROJECT_VERSION_PATCH},0")
2321
set(GRAPHQL_RC_VERSION_STR "${PROJECT_VERSION}")
2422

@@ -40,11 +38,17 @@ if(GRAPHQL_UPDATE_VERSION)
4038
endfunction()
4139
endif()
4240

43-
if(WIN32 AND BUILD_SHARED_LIBS)
44-
function(add_version_rc target)
45-
add_library(${target}_version OBJECT ${CMAKE_CURRENT_SOURCE_DIR}/../res/${target}_version.rc)
46-
target_link_libraries(${target} PRIVATE ${target}_version)
47-
endfunction()
41+
if(WIN32)
42+
# Always build the version.rc files with these flags, even if we aren't regnerating them.
43+
set(CMAKE_RC_FLAGS "/nologo")
44+
set(CMAKE_RC_FLAGS_DEBUG "/dDEBUG")
45+
46+
if(BUILD_SHARED_LIBS)
47+
function(add_version_rc target)
48+
add_library(${target}_version OBJECT ${CMAKE_CURRENT_SOURCE_DIR}/../res/${target}_version.rc)
49+
target_link_libraries(${target} PRIVATE ${target}_version)
50+
endfunction()
51+
endif()
4852
endif()
4953

5054
function(add_bigobj_flag target)

0 commit comments

Comments
 (0)