Cleanup some error handling

Author: wravery

src/GraphQLResponse.cpp

@@ -675,7 +675,9 @@ IdType Value::release<IdType>()
 		{
 			auto stringValue = std::move(stringData.string);
 
-			return internal::Base64::fromBase64(stringValue);
+			return internal::Base64::validateBase64(stringValue)
+				? IdType { internal::Base64::fromBase64(stringValue) }
+				: IdType { std::move(stringValue) };
 		}
 	}
 	else if (std::holds_alternative<IdType>(_data))

src/GraphQLService.cpp

@@ -674,14 +674,7 @@ response::IdType ModifiedArgument<response::IdType>::convert(const response::Val
 		throw schema_exception { { "not an ID" } };
 	}
 
-	try
-	{
-		return response::Value { value }.release<response::IdType>();
-	}
-	catch (const std::logic_error& ex)
-	{
-		throw schema_exception { { ex.what() } };
-	}
+	return response::Value { value }.release<response::IdType>();
 }
 
 void blockSubFields(const ResolverParams& params)
@@ -852,15 +845,6 @@ void ModifiedResult<response::IdType>::validateScalar(const response::Value& val
 	{
 		throw schema_exception { { R"ex(not a valid ID value)ex" } };
 	}
-
-	try
-	{
-		value.get<response::IdType>();
-	}
-	catch (const std::logic_error& ex)
-	{
-		throw schema_exception { { ex.what() } };
-	}
 }
 
 template <>