Skip to content

Commit a07309e

Browse files
committed
Replace iterator constructors with a template
1 parent c738db9 commit a07309e

File tree

2 files changed

+6
-21
lines changed

2 files changed

+6
-21
lines changed

include/graphqlservice/GraphQLResponse.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,12 @@ struct [[nodiscard]] IdType
6868
// Implicit ByteData constructors
6969
GRAPHQLRESPONSE_EXPORT IdType(size_t count, typename ByteData::value_type value = 0);
7070
GRAPHQLRESPONSE_EXPORT IdType(std::initializer_list<typename ByteData::value_type> values);
71-
GRAPHQLRESPONSE_EXPORT IdType(
72-
typename ByteData::const_iterator begin, typename ByteData::const_iterator end);
73-
GRAPHQLRESPONSE_EXPORT IdType(
74-
typename ByteData::const_pointer begin, typename ByteData::const_pointer end);
71+
72+
template <typename InputIt>
73+
IdType(InputIt begin, InputIt end)
74+
: _data { ByteData { begin, end } }
75+
{
76+
}
7577

7678
// Assignment
7779
GRAPHQLRESPONSE_EXPORT IdType& operator=(IdType&& rhs) noexcept;
@@ -80,7 +82,6 @@ struct [[nodiscard]] IdType
8082
// Conversion
8183
GRAPHQLRESPONSE_EXPORT IdType(ByteData&& data) noexcept;
8284
GRAPHQLRESPONSE_EXPORT IdType& operator=(ByteData&& data) noexcept;
83-
GRAPHQLRESPONSE_EXPORT IdType& operator=(std::initializer_list<typename ByteData::value_type> values);
8485

8586
GRAPHQLRESPONSE_EXPORT IdType(OpaqueString&& opaque) noexcept;
8687
GRAPHQLRESPONSE_EXPORT IdType& operator=(OpaqueString&& opaque) noexcept;

src/GraphQLResponse.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,6 @@ IdType::IdType(std::initializer_list<typename ByteData::value_type> values)
4141
{
4242
}
4343

44-
IdType::IdType(typename ByteData::const_iterator begin, typename ByteData::const_iterator end)
45-
: _data { ByteData { begin, end } }
46-
{
47-
}
48-
49-
IdType::IdType(typename ByteData::const_pointer begin, typename ByteData::const_pointer end)
50-
: _data { ByteData { begin, end } }
51-
{
52-
}
53-
5444
IdType& IdType::operator=(IdType&& rhs) noexcept
5545
{
5646
if (&rhs != this)
@@ -72,12 +62,6 @@ IdType& IdType::operator=(ByteData&& data) noexcept
7262
return *this;
7363
}
7464

75-
IdType& IdType::operator=(std::initializer_list<typename IdType::ByteData::value_type> values)
76-
{
77-
_data = ByteData { values };
78-
return *this;
79-
}
80-
8165
IdType::IdType(OpaqueString&& opaque) noexcept
8266
: _data { std::move(opaque) }
8367
{

0 commit comments

Comments
 (0)