Skip to content

Commit 634e01f

Browse files
committed
Make testTaskStatus non-nullable so test default enum init
1 parent c092c11 commit 634e01f

File tree

14 files changed

+22
-25
lines changed

14 files changed

+22
-25
lines changed

samples/client/QueryClient.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ Response parseResponse(response::Value&& response)
453453
}
454454
if (member.first == R"js(testTaskState)js"sv)
455455
{
456-
result.testTaskState = ModifiedResponse<TaskState>::parse<TypeModifier::Nullable>(std::move(member.second));
456+
result.testTaskState = ModifiedResponse<TaskState>::parse(std::move(member.second));
457457
continue;
458458
}
459459
if (member.first == R"js(anyType)js"sv)

samples/client/QueryClient.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ struct Response
169169

170170
unreadCounts_FolderConnection unreadCounts {};
171171

172-
std::optional<TaskState> testTaskState {};
172+
TaskState testTaskState {};
173173
struct anyType_UnionType
174174
{
175175
response::StringType _typename {};

samples/schema.today.graphql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type Query {
3333

3434
expensive: [Expensive!]!
3535

36-
testTaskState: TaskState
36+
testTaskState: TaskState!
3737

3838
anyType(ids: [ID!]!): [UnionType]!
3939
}

samples/separate/QueryObject.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ std::future<service::ResolverResult> Query::resolveExpensive(service::ResolverPa
230230
return service::ModifiedResult<Expensive>::convert<service::TypeModifier::List>(std::move(result), std::move(params));
231231
}
232232

233-
service::FieldResult<std::optional<TaskState>> Query::getTestTaskState(service::FieldParams&&) const
233+
service::FieldResult<TaskState> Query::getTestTaskState(service::FieldParams&&) const
234234
{
235235
throw std::runtime_error(R"ex(Query::getTestTaskState is not implemented)ex");
236236
}
@@ -242,7 +242,7 @@ std::future<service::ResolverResult> Query::resolveTestTaskState(service::Resolv
242242
auto result = getTestTaskState(service::FieldParams(std::move(params), std::move(directives)));
243243
resolverLock.unlock();
244244

245-
return service::ModifiedResult<TaskState>::convert<service::TypeModifier::Nullable>(std::move(result), std::move(params));
245+
return service::ModifiedResult<TaskState>::convert(std::move(result), std::move(params));
246246
}
247247

248248
service::FieldResult<std::vector<std::shared_ptr<service::Object>>> Query::getAnyType(service::FieldParams&&, std::vector<response::IdType>&&) const
@@ -318,7 +318,7 @@ void AddQueryDetails(std::shared_ptr<schema::ObjectType> typeQuery, const std::s
318318
schema::Field::Make(R"gql(nested)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("NestedType"))),
319319
schema::Field::Make(R"gql(unimplemented)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("String"))),
320320
schema::Field::Make(R"gql(expensive)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("Expensive"))))),
321-
schema::Field::Make(R"gql(testTaskState)gql"sv, R"md()md"sv, std::nullopt, schema->LookupType("TaskState")),
321+
schema::Field::Make(R"gql(testTaskState)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("TaskState"))),
322322
schema::Field::Make(R"gql(anyType)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->LookupType("UnionType"))), {
323323
schema::InputValue::Make(R"gql(ids)gql"sv, R"md()md"sv, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("ID")))), R"gql()gql"sv)
324324
})

samples/separate/QueryObject.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class Query
2929
virtual service::FieldResult<std::shared_ptr<NestedType>> getNested(service::FieldParams&& params) const;
3030
virtual service::FieldResult<response::StringType> getUnimplemented(service::FieldParams&& params) const;
3131
virtual service::FieldResult<std::vector<std::shared_ptr<Expensive>>> getExpensive(service::FieldParams&& params) const;
32-
virtual service::FieldResult<std::optional<TaskState>> getTestTaskState(service::FieldParams&& params) const;
32+
virtual service::FieldResult<TaskState> getTestTaskState(service::FieldParams&& params) const;
3333
virtual service::FieldResult<std::vector<std::shared_ptr<service::Object>>> getAnyType(service::FieldParams&& params, std::vector<response::IdType>&& idsArg) const;
3434

3535
private:

samples/separate_nointrospection/QueryObject.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ std::future<service::ResolverResult> Query::resolveExpensive(service::ResolverPa
227227
return service::ModifiedResult<Expensive>::convert<service::TypeModifier::List>(std::move(result), std::move(params));
228228
}
229229

230-
service::FieldResult<std::optional<TaskState>> Query::getTestTaskState(service::FieldParams&&) const
230+
service::FieldResult<TaskState> Query::getTestTaskState(service::FieldParams&&) const
231231
{
232232
throw std::runtime_error(R"ex(Query::getTestTaskState is not implemented)ex");
233233
}
@@ -239,7 +239,7 @@ std::future<service::ResolverResult> Query::resolveTestTaskState(service::Resolv
239239
auto result = getTestTaskState(service::FieldParams(std::move(params), std::move(directives)));
240240
resolverLock.unlock();
241241

242-
return service::ModifiedResult<TaskState>::convert<service::TypeModifier::Nullable>(std::move(result), std::move(params));
242+
return service::ModifiedResult<TaskState>::convert(std::move(result), std::move(params));
243243
}
244244

245245
service::FieldResult<std::vector<std::shared_ptr<service::Object>>> Query::getAnyType(service::FieldParams&&, std::vector<response::IdType>&&) const
@@ -301,7 +301,7 @@ void AddQueryDetails(std::shared_ptr<schema::ObjectType> typeQuery, const std::s
301301
schema::Field::Make(R"gql(nested)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("NestedType"))),
302302
schema::Field::Make(R"gql(unimplemented)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("String"))),
303303
schema::Field::Make(R"gql(expensive)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("Expensive"))))),
304-
schema::Field::Make(R"gql(testTaskState)gql"sv, R"md()md"sv, std::nullopt, schema->LookupType("TaskState")),
304+
schema::Field::Make(R"gql(testTaskState)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("TaskState"))),
305305
schema::Field::Make(R"gql(anyType)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->LookupType("UnionType"))), {
306306
schema::InputValue::Make(R"gql(ids)gql"sv, R"md()md"sv, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("ID")))), R"gql()gql"sv)
307307
})

samples/separate_nointrospection/QueryObject.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class Query
2929
virtual service::FieldResult<std::shared_ptr<NestedType>> getNested(service::FieldParams&& params) const;
3030
virtual service::FieldResult<response::StringType> getUnimplemented(service::FieldParams&& params) const;
3131
virtual service::FieldResult<std::vector<std::shared_ptr<Expensive>>> getExpensive(service::FieldParams&& params) const;
32-
virtual service::FieldResult<std::optional<TaskState>> getTestTaskState(service::FieldParams&& params) const;
32+
virtual service::FieldResult<TaskState> getTestTaskState(service::FieldParams&& params) const;
3333
virtual service::FieldResult<std::vector<std::shared_ptr<service::Object>>> getAnyType(service::FieldParams&& params, std::vector<response::IdType>&& idsArg) const;
3434

3535
private:

samples/today/TodayMock.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,8 +424,7 @@ service::FieldResult<std::vector<std::shared_ptr<object::Expensive>>> Query::get
424424
return result;
425425
}
426426

427-
service::FieldResult<std::optional<TaskState>> Query::getTestTaskState(
428-
service::FieldParams&& /*params*/) const
427+
service::FieldResult<TaskState> Query::getTestTaskState(service::FieldParams&& /*params*/) const
429428
{
430429
return TaskState::Unassigned;
431430
}

samples/today/TodayMock.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ class Query : public object::Query
7474
service::FieldParams&& params) const final;
7575
service::FieldResult<std::vector<std::shared_ptr<object::Expensive>>> getExpensive(
7676
service::FieldParams&& params) const final;
77-
service::FieldResult<std::optional<TaskState>> getTestTaskState(
78-
service::FieldParams&& params) const final;
77+
service::FieldResult<TaskState> getTestTaskState(service::FieldParams&& params) const final;
7978
service::FieldResult<std::vector<std::shared_ptr<service::Object>>> getAnyType(
8079
service::FieldParams&& params, std::vector<response::IdType>&& idsArg) const final;
8180

samples/unified/TodaySchema.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ std::future<service::ResolverResult> Query::resolveExpensive(service::ResolverPa
353353
return service::ModifiedResult<Expensive>::convert<service::TypeModifier::List>(std::move(result), std::move(params));
354354
}
355355

356-
service::FieldResult<std::optional<TaskState>> Query::getTestTaskState(service::FieldParams&&) const
356+
service::FieldResult<TaskState> Query::getTestTaskState(service::FieldParams&&) const
357357
{
358358
throw std::runtime_error(R"ex(Query::getTestTaskState is not implemented)ex");
359359
}
@@ -365,7 +365,7 @@ std::future<service::ResolverResult> Query::resolveTestTaskState(service::Resolv
365365
auto result = getTestTaskState(service::FieldParams(std::move(params), std::move(directives)));
366366
resolverLock.unlock();
367367

368-
return service::ModifiedResult<TaskState>::convert<service::TypeModifier::Nullable>(std::move(result), std::move(params));
368+
return service::ModifiedResult<TaskState>::convert(std::move(result), std::move(params));
369369
}
370370

371371
service::FieldResult<std::vector<std::shared_ptr<service::Object>>> Query::getAnyType(service::FieldParams&&, std::vector<response::IdType>&&) const
@@ -1306,7 +1306,7 @@ void AddTypesToSchema(const std::shared_ptr<schema::Schema>& schema)
13061306
schema::Field::Make(R"gql(nested)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("NestedType"))),
13071307
schema::Field::Make(R"gql(unimplemented)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("String"))),
13081308
schema::Field::Make(R"gql(expensive)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("Expensive"))))),
1309-
schema::Field::Make(R"gql(testTaskState)gql"sv, R"md()md"sv, std::nullopt, schema->LookupType("TaskState")),
1309+
schema::Field::Make(R"gql(testTaskState)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("TaskState"))),
13101310
schema::Field::Make(R"gql(anyType)gql"sv, R"md()md"sv, std::nullopt, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->LookupType("UnionType"))), {
13111311
schema::InputValue::Make(R"gql(ids)gql"sv, R"md()md"sv, schema->WrapType(introspection::TypeKind::NON_NULL, schema->WrapType(introspection::TypeKind::LIST, schema->WrapType(introspection::TypeKind::NON_NULL, schema->LookupType("ID")))), R"gql()gql"sv)
13121312
})

0 commit comments

Comments
 (0)