Implement Directive validation

Author: wravery

src/Validation.cpp

@@ -2022,6 +2022,8 @@ void ValidateExecutableVisitor::visitInlineFragment(const peg::ast_node& inlineF
 
 void ValidateExecutableVisitor::visitDirectives(introspection::DirectiveLocation location, const peg::ast_node& directives)
 {
+	std::set<std::string> uniqueDirectives;
+
 	for (const auto& directive : directives.children)
 	{
 		std::string directiveName;
@@ -2032,6 +2034,18 @@ void ValidateExecutableVisitor::visitDirectives(introspection::DirectiveLocation
 			directiveName = child.string_view();
 		});
 
+		if (!uniqueDirectives.insert(directiveName).second)
+		{
+			// http://spec.graphql.org/June2018/#sec-Directives-Are-Unique-Per-Location
+			auto position = directive->begin();
+			std::ostringstream message;
+
+			message << "Conflicting directive name: " << directiveName;
+
+			_errors.push_back({ message.str(), { position.line, position.byte_in_line } });
+			continue;
+		}
+
 		auto itrDirective = _directives.find(directiveName);
 
 		if (itrDirective == _directives.end())
@@ -2046,6 +2060,52 @@ void ValidateExecutableVisitor::visitDirectives(introspection::DirectiveLocation
 			continue;
 		}
 
+		if (itrDirective->second.locations.find(location) == itrDirective->second.locations.end())
+		{
+			// http://spec.graphql.org/June2018/#sec-Directives-Are-In-Valid-Locations
+			auto position = directive->begin();
+			std::ostringstream message;
+
+			message << "Unexpected location for directive: " << directiveName;
+
+			switch (location)
+			{
+				case introspection::DirectiveLocation::QUERY:
+					message << " name: QUERY";
+					break;
+
+				case introspection::DirectiveLocation::MUTATION:
+					message << " name: MUTATION";
+					break;
+
+				case introspection::DirectiveLocation::SUBSCRIPTION:
+					message << " name: SUBSCRIPTION";
+					break;
+
+				case introspection::DirectiveLocation::FIELD:
+					message << " name: FIELD";
+					break;
+
+				case introspection::DirectiveLocation::FRAGMENT_DEFINITION:
+					message << " name: FRAGMENT_DEFINITION";
+					break;
+
+				case introspection::DirectiveLocation::FRAGMENT_SPREAD:
+					message << " name: FRAGMENT_SPREAD";
+					break;
+
+				case introspection::DirectiveLocation::INLINE_FRAGMENT:
+					message << " name: INLINE_FRAGMENT";
+					break;
+
+				default:
+					break;
+			}
+
+			_errors.push_back({ message.str(), { position.line, position.byte_in_line } });
+			continue;
+		}
+
 		peg::on_first_child<peg::arguments>(*directive,
 			[this, &directive, &directiveName, itrDirective](const peg::ast_node& child)
 		{

test/ValidationTests.cpp

@@ -1272,3 +1272,52 @@ TEST_F(ValidationExamplesCase, CounterExample149)
 	ASSERT_GE(errors.size(), size_t{ 1 });
 	EXPECT_EQ(R"js({"message":"Conflicting input field name: name","locations":[{"line":2,"column":37}]})js", response::toJSON(std::move(errors[0]))) << "error should match";
 }
+
+TEST_F(ValidationExamplesCase, CounterExample150)
+{
+	// http://spec.graphql.org/June2018/#example-55f3f
+	auto query = R"(query @skip(if: $foo) {
+			dog {
+				name
+			}
+		})"_graphql;
+
+	auto errors = service::buildErrorValues(_service->validate(query)).release<response::ListType>();
+
+	EXPECT_EQ(errors.size(), 1) << "1 unexpected location";
+	ASSERT_GE(errors.size(), size_t{ 1 });
+	EXPECT_EQ(R"js({"message":"Unexpected location for directive: skip name: QUERY","locations":[{"line":1,"column":7}]})js", response::toJSON(std::move(errors[0]))) << "error should match";
+}
+
+TEST_F(ValidationExamplesCase, CounterExample151)
+{
+	// http://spec.graphql.org/June2018/#example-b2e6c
+	auto query = R"(query ($foo: Boolean = true, $bar: Boolean = false) {
+			dog @skip(if: $foo) @skip(if: $bar) {
+				name
+			}
+		})"_graphql;
+
+	auto errors = service::buildErrorValues(_service->validate(query)).release<response::ListType>();
+
+	EXPECT_EQ(errors.size(), 1) << "1 conflicting directive";
+	ASSERT_GE(errors.size(), size_t{ 1 });
+	EXPECT_EQ(R"js({"message":"Conflicting directive name: skip","locations":[{"line":2,"column":24}]})js", response::toJSON(std::move(errors[0]))) << "error should match";
+}
+
+TEST_F(ValidationExamplesCase, Example152)
+{
+	// http://spec.graphql.org/June2018/#example-c5ee9
+	auto query = R"(query ($foo: Boolean = true, $bar: Boolean = false) {
+			dog @skip(if: $foo) {
+				name
+			}
+			dog @skip(if: $bar) {
+				nickname
+			}
+		})"_graphql;
+
+	auto errors = service::buildErrorValues(_service->validate(query)).release<response::ListType>();
+
+	ASSERT_TRUE(errors.empty());
+}