Add a test for unimplemented field errors

Author: wravery

samples/TodaySchema.cpp

@@ -106,6 +106,7 @@ Query::Query()
 		{ "tasksById", [this](service::ResolverParams&& params) { return resolveTasksById(std::move(params)); } },
 		{ "unreadCountsById", [this](service::ResolverParams&& params) { return resolveUnreadCountsById(std::move(params)); } },
 		{ "nested", [this](service::ResolverParams&& params) { return resolveNested(std::move(params)); } },
+		{ "unimplemented", [this](service::ResolverParams&& params) { return resolveUnimplemented(std::move(params)); } },
 		{ "__typename", [this](service::ResolverParams&& params) { return resolve__typename(std::move(params)); } },
 		{ "__schema", [this](service::ResolverParams&& params) { return resolve__schema(std::move(params)); } },
 		{ "__type", [this](service::ResolverParams&& params) { return resolve__type(std::move(params)); } }
@@ -282,6 +283,22 @@ std::future<response::Value> Query::resolveNested(service::ResolverParams&& para
 	return service::ModifiedResult<NestedType>::convert(std::move(result), std::move(params));
 }
 
+std::future<response::StringType> Query::getUnimplemented(service::FieldParams&&) const
+{
+	std::promise<response::StringType> promise;
+
+	promise.set_exception(std::make_exception_ptr(std::runtime_error(R"ex(Query::getUnimplemented is not implemented)ex")));
+
+	return promise.get_future();
+}
+
+std::future<response::Value> Query::resolveUnimplemented(service::ResolverParams&& params)
+{
+	auto result = getUnimplemented(service::FieldParams(params, std::move(params.fieldDirectives)));
+
+	return service::ModifiedResult<response::StringType>::convert(std::move(result), std::move(params));
+}
+
 std::future<response::Value> Query::resolve__typename(service::ResolverParams&& params)
 {
 	std::promise<response::StringType> promise;
@@ -1205,7 +1222,8 @@ void AddTypesToSchema(std::shared_ptr<introspection::Schema> schema)
 		std::make_shared<introspection::Field>("unreadCountsById", R"md()md", std::unique_ptr<std::string>(nullptr), std::vector<std::shared_ptr<introspection::InputValue>>({
 			std::make_shared<introspection::InputValue>("ids", R"md()md", schema->WrapType(introspection::__TypeKind::NON_NULL, schema->WrapType(introspection::__TypeKind::LIST, schema->WrapType(introspection::__TypeKind::NON_NULL, schema->LookupType("ID")))), R"gql()gql")
 		}), schema->WrapType(introspection::__TypeKind::NON_NULL, schema->WrapType(introspection::__TypeKind::LIST, schema->LookupType("Folder")))),
-		std::make_shared<introspection::Field>("nested", R"md()md", std::unique_ptr<std::string>(nullptr), std::vector<std::shared_ptr<introspection::InputValue>>(), schema->WrapType(introspection::__TypeKind::NON_NULL, schema->LookupType("NestedType")))
+		std::make_shared<introspection::Field>("nested", R"md()md", std::unique_ptr<std::string>(nullptr), std::vector<std::shared_ptr<introspection::InputValue>>(), schema->WrapType(introspection::__TypeKind::NON_NULL, schema->LookupType("NestedType"))),
+		std::make_shared<introspection::Field>("unimplemented", R"md()md", std::unique_ptr<std::string>(nullptr), std::vector<std::shared_ptr<introspection::InputValue>>(), schema->WrapType(introspection::__TypeKind::NON_NULL, schema->LookupType("String")))
 	});
 	typePageInfo->AddFields({
 		std::make_shared<introspection::Field>("hasNextPage", R"md()md", std::unique_ptr<std::string>(nullptr), std::vector<std::shared_ptr<introspection::InputValue>>(), schema->WrapType(introspection::__TypeKind::NON_NULL, schema->LookupType("Boolean"))),

samples/TodaySchema.h

@@ -76,6 +76,7 @@ class Query
 	virtual std::future<std::vector<std::shared_ptr<Task>>> getTasksById(service::FieldParams&& params, std::vector<std::vector<uint8_t>>&& idsArg) const;
 	virtual std::future<std::vector<std::shared_ptr<Folder>>> getUnreadCountsById(service::FieldParams&& params, std::vector<std::vector<uint8_t>>&& idsArg) const;
 	virtual std::future<std::shared_ptr<NestedType>> getNested(service::FieldParams&& params) const;
+	virtual std::future<response::StringType> getUnimplemented(service::FieldParams&& params) const;
 
 private:
 	std::future<response::Value> resolveNode(service::ResolverParams&& params);
@@ -86,6 +87,7 @@ class Query
 	std::future<response::Value> resolveTasksById(service::ResolverParams&& params);
 	std::future<response::Value> resolveUnreadCountsById(service::ResolverParams&& params);
 	std::future<response::Value> resolveNested(service::ResolverParams&& params);
+	std::future<response::Value> resolveUnimplemented(service::ResolverParams&& params);
 
 	std::future<response::Value> resolve__typename(service::ResolverParams&& params);
 	std::future<response::Value> resolve__schema(service::ResolverParams&& params);

samples/schema.today.graphql

@@ -26,6 +26,8 @@ type Query {
     unreadCountsById(ids: [ID!]!): [Folder]!
 
     nested: NestedType!
+
+    unimplemented: String!
 }
 
 "Node interface for Relay support"

tests.cpp

@@ -838,6 +838,30 @@ TEST_F(TodayServiceCase, QueryAppointmentsById)
 	}
 }
 
+TEST_F(TodayServiceCase, UnimplementedFieldError)
+{
+	auto ast = R"(query {
+			unimplemented
+		})"_graphql;
+	response::Value variables(response::Type::Map);
+	auto result = _service->resolve(nullptr, *ast.root, "", std::move(variables)).get();
+
+	try
+	{
+		ASSERT_TRUE(result.type() == response::Type::Map);
+		const auto& errors = result["errors"];
+		ASSERT_TRUE(errors.type() == response::Type::List);
+		ASSERT_EQ(size_t(1), errors.size());
+		const auto& message = errors[0];
+		ASSERT_TRUE(message.type() == response::Type::String);
+		ASSERT_EQ(R"e(Field name: unimplemented unknown error: Query::getUnimplemented is not implemented)e", message.get<const response::StringType&>());
+	}
+	catch (const service::schema_exception& ex)
+	{
+		FAIL() << response::toJSON(response::Value(ex.getErrors()));
+	}
+}
+
 TEST_F(TodayServiceCase, SubscribeNodeChangeMatchingId)
 {
 	auto ast = peg::parseString(R"(subscription TestSubscription {