Fix warning about returning a ref to temporary

wravery · wravery · commit 11706e6bb29a · 2019-01-04T19:56:19.000-05:00
diff --git a/Introspection.cpp b/Introspection.cpp
@@ -34,14 +34,7 @@ void Schema::AddType(response::StringType name, std::shared_ptr<object::__Type>
 
 const std::shared_ptr<object::__Type>& Schema::LookupType(const response::StringType& name) const
 {
-	auto itr = _typeMap.find(name);
-
-	if (itr == _typeMap.cend())
-	{
-		return nullptr;
-	}
-
-	return _types[itr->second].second;
+	return _types[_typeMap.find(name)->second].second;
 }
 
 void Schema::AddDirective(std::shared_ptr<object::__Directive> directive)

Original file line number	Diff line number	Diff line change
`@@ -34,14 +34,7 @@ void Schema::AddType(response::StringType name, std::shared_ptr<object::__Type>`
`34`	`34`
`35`	`35`	`const std::shared_ptr<object::__Type>& Schema::LookupType(const response::StringType& name) const`
`36`	`36`	`{`
`37`		`- auto itr = _typeMap.find(name);`
`38`		`-`
`39`		`- if (itr == _typeMap.cend())`
`40`		`- {`
`41`		`- return nullptr;`
`42`		`- }`
`43`		`-`
`44`		`- return _types[itr->second].second;`
	`37`	`+ return _types[_typeMap.find(name)->second].second;`
`45`	`38`	`}`
`46`	`39`
`47`	`40`	`void Schema::AddDirective(std::shared_ptr<object::__Directive> directive)`