Merge pull request #510 from microsoft/eduardo-camacho/feature/objc-int64

eduardo-camacho · web-flow · commit dbb2c16258e3 · 2020-07-12T10:01:16.000-07:00
Issue #500: Fix handing of int64 values at Obj-C wrapper when sending event
diff --git a/wrappers/obj-c/ODWLogger.mm b/wrappers/obj-c/ODWLogger.mm
@@ -64,10 +64,10 @@ -(void) unwrapEventProperties: (ODWEventProperties*) wrappedProperties onEvent:(
             if(strcmp([num objCType], @encode(BOOL))==0 ) {
                 event.SetProperty(strPropertyName, [num boolValue] ? true : false, piiKind);
             }
-            else if( strcmp([num objCType], @encode(int))==0 ){
-                event.SetProperty(strPropertyName, [num intValue], piiKind);
-            }else{
+            else if( (strcmp([num objCType], @encode(float))==0) || (strcmp([num objCType], @encode(double))==0) || (strcmp([num objCType], @encode(long double))==0) ){
                 event.SetProperty(strPropertyName, [num floatValue], piiKind);
+            }else{
+                event.SetProperty(strPropertyName, [num longLongValue], piiKind);
             }
         }
         else if([value isKindOfClass: [NSDate class]])

Original file line number	Diff line number	Diff line change
`@@ -64,10 +64,10 @@ -(void) unwrapEventProperties: (ODWEventProperties*) wrappedProperties onEvent:(`
`64`	`64`	`if(strcmp([num objCType], @encode(BOOL))==0 ) {`
`65`	`65`	`event.SetProperty(strPropertyName, [num boolValue] ? true : false, piiKind);`
`66`	`66`	`}`
`67`		`- else if( strcmp([num objCType], @encode(int))==0 ){`
`68`		`- event.SetProperty(strPropertyName, [num intValue], piiKind);`
`69`		`- }else{`
	`67`	`+ else if( (strcmp([num objCType], @encode(float))==0) \|\| (strcmp([num objCType], @encode(double))==0) \|\| (strcmp([num objCType], @encode(long double))==0) ){`
`70`	`68`	`event.SetProperty(strPropertyName, [num floatValue], piiKind);`
	`69`	`+ }else{`
	`70`	`+ event.SetProperty(strPropertyName, [num longLongValue], piiKind);`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`	`else if([value isKindOfClass: [NSDate class]])`