Skip to content

Commit 0313da4

Browse files
author
Phoebe Szmucer
committed
CR
1 parent 2a07919 commit 0313da4

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/services/stringCompletions.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -647,13 +647,10 @@ function getSupportedExtensionsForModuleResolution(compilerOptions: CompilerOpti
647647
*/
648648
function getBaseDirectoriesFromRootDirs(rootDirs: string[], basePath: string, scriptDirectory: string, ignoreCase: boolean): readonly string[] {
649649
// Make all paths absolute/normalized if they are not already
650-
rootDirs = rootDirs.map(rootDirectory => normalizePath(isRootedDiskPath(rootDirectory) ? rootDirectory : combinePaths(basePath, rootDirectory)));
650+
rootDirs = rootDirs.map(rootDirectory => ensureTrailingDirectorySeparator(normalizePath(isRootedDiskPath(rootDirectory) ? rootDirectory : combinePaths(basePath, rootDirectory))));
651651

652652
// Determine the path to the directory containing the script relative to the root directory it is contained within
653-
const relativeDirectory = firstDefined(rootDirs, rootDirectory => {
654-
const rootDirectoryWithSlash = rootDirectory.endsWith("/") ? rootDirectory : rootDirectory + "/";
655-
return containsPath(rootDirectoryWithSlash, scriptDirectory, basePath, ignoreCase) ? scriptDirectory.substr(rootDirectoryWithSlash.length) : undefined;
656-
})!; // TODO: GH#18217
653+
const relativeDirectory = firstDefined(rootDirs, rootDirectory => containsPath(rootDirectory, scriptDirectory, basePath, ignoreCase) ? scriptDirectory.substr(rootDirectory.length) : undefined)!; // TODO: GH#18217
657654

658655
// Now find a path for each potential directory that is to be merged with the one containing the script
659656
return deduplicate<string>(

0 commit comments

Comments
 (0)