Skip to content

Commit 40dacea

Browse files
authored
CMake targets fixes for optional vs. required packages (#369)
1 parent 71aa6ba commit 40dacea

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

CMakeLists.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ if(BUILD_TOOLS AND BUILD_DX11 AND WIN32)
287287
Texassemble/texassemble.rc
288288
Texassemble/settings.manifest
289289
Texassemble/AnimatedGif.cpp)
290-
target_link_libraries(texassemble ${PROJECT_NAME} ole32.lib version.lib)
290+
target_link_libraries(texassemble PRIVATE ${PROJECT_NAME} ole32.lib version.lib)
291291
source_group(texassemble REGULAR_EXPRESSION Texassemble/*.*)
292292

293293
add_executable(texconv
@@ -296,24 +296,24 @@ if(BUILD_TOOLS AND BUILD_DX11 AND WIN32)
296296
Texconv/settings.manifest
297297
Texconv/ExtendedBMP.cpp
298298
Texconv/PortablePixMap.cpp)
299-
target_link_libraries(texconv ${PROJECT_NAME} ole32.lib shell32.lib version.lib)
299+
target_link_libraries(texconv PRIVATE ${PROJECT_NAME} ole32.lib shell32.lib version.lib)
300300
source_group(texconv REGULAR_EXPRESSION Texconv/*.*)
301301

302302
add_executable(texdiag
303303
Texdiag/texdiag.cpp
304304
Texdiag/texdiag.rc
305305
Texdiag/settings.manifest)
306-
target_link_libraries(texdiag ${PROJECT_NAME} ole32.lib version.lib)
306+
target_link_libraries(texdiag PRIVATE ${PROJECT_NAME} ole32.lib version.lib)
307307
source_group(texdiag REGULAR_EXPRESSION Texdiag/*.*)
308308

309309
if(BC_USE_OPENMP)
310-
target_link_libraries(texconv OpenMP::OpenMP_CXX)
310+
target_link_libraries(texconv PRIVATE OpenMP::OpenMP_CXX)
311311
endif()
312312

313313
if(ENABLE_OPENEXR_SUPPORT)
314314
foreach(t IN LISTS TOOL_EXES)
315315
target_include_directories(${t} PRIVATE Auxiliary)
316-
target_link_libraries(${t} ${OPENEXR_ILMIMF_LIBRARY})
316+
target_link_libraries(${t} PRIVATE ${OPENEXR_ILMIMF_LIBRARY})
317317
target_compile_options(${t} PRIVATE -DUSE_OPENEXR)
318318
endforeach()
319319
endif()
@@ -337,7 +337,7 @@ if(BUILD_SAMPLE AND BUILD_DX11 AND WIN32)
337337
DDSView/ddsview.cpp
338338
DDSView/ddsview.rc
339339
${COMPILED_DDSVIEW_SHADERS}/ddsview_ps1D.inc)
340-
target_link_libraries(ddsview ${PROJECT_NAME} d3d11.lib ole32.lib)
340+
target_link_libraries(ddsview PRIVATE ${PROJECT_NAME} d3d11.lib ole32.lib)
341341
source_group(ddsview REGULAR_EXPRESSION DDSView/*.*)
342342

343343
target_include_directories(ddsview PRIVATE ${COMPILED_DDSVIEW_SHADERS})
@@ -356,7 +356,7 @@ endif()
356356

357357
if(directxmath_FOUND)
358358
foreach(t IN LISTS TOOL_EXES)
359-
target_link_libraries(${t} Microsoft::DirectXMath)
359+
target_link_libraries(${t} PRIVATE Microsoft::DirectXMath)
360360
endforeach()
361361
endif()
362362

build/DirectXTex-config.cmake.in

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,11 @@ if(ENABLE_OPENEXR_SUPPORT)
1414
endif()
1515

1616
if(MINGW OR (NOT WIN32))
17-
find_dependency(directx-headers CONFIG)
18-
find_dependency(directxmath CONFIG)
17+
find_dependency(directx-headers)
18+
find_dependency(directxmath)
19+
else()
20+
find_package(directx-headers CONFIG QUIET)
21+
find_package(directxmath CONFIG QUIET)
1922
endif()
2023

2124
check_required_components("@PROJECT_NAME@")

0 commit comments

Comments
 (0)