Always upload build artefacts to the pull request

[tino-teuber]

Hello!

Is there a way that the build artefacts (app, test app, dependencies) are always attached to the pull request?

When I look at the pull request handler workflow, it seems that the build artefacts are not attached due to the following condition:

AL-Go/Templates/AppSource App/.github/workflows/PullRequestHandler.yaml

Line 103 in ff6ed57

publishThisBuildArtifacts: ${{ needs.Initialization.outputs.workflowDepth > 1 }}

Can I perhaps use a setting to ensure that the build artefacts are always uploaded to the pull request?

Thank you very much! 🙏

[freddydk]

Right now, there is no such setting.
What would the purpose be of storing build artifacts from PRs?
How/why would you use them?

[tino-teuber]

The build artifacts (the BC apps) are required by our consultants to test the functionality. Only when the code review (Developer) and functional test (Consultant) are positive are the changes merged into the main branch.

We are currently stuck with AL-Go version 2.4 because - according to my information - it is the last version that uploads build artifacts in the pull request.

[freddydk]

Will investigate what we can do

[freddydk]

Even if we create artifacts on the PR - they would need to manually deploy those right?
QQ - why wouldn't you have a feature branch on which CI/CD would push the feature to a QA environment, which could be tested by the reviewer?

[tino-teuber]

Yes, that's right. Our consultants still have to publish the artifacts manually (install the BC apps in the BC Extension Management)

Our consultants - who do not have access to GitHub - decide for themselves when to test which feature. They test each feature individually in their QR environment (BC Cloud Sandbox).

[tino-teuber]

I have just discovered the pull request [DRAFT] Add support for indirect template + customisations. Couldn't I also implement the upload of build artifacts with the ‘Custom Steps’ and ‘Custom Jobs’ features implemented in the pull request?

[freddydk]

In the latest version of AL-Go for GitHub we have implemented Publish To Environment from Pull Request - and artifacts are now always published on PRs.