Skip to content

Commit a2e1b9c

Browse files
committed
use a more specific exception for unknown opcode
1 parent 5f76237 commit a2e1b9c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

esp32_ulp/assemble.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def assembler_pass(self, lines):
271271
instruction = func(*args)
272272
self.append_section(instruction.to_bytes(4, 'little'), TEXT)
273273
continue
274-
raise Exception('Unknown opcode or directive: %s' % opcode)
274+
raise ValueError('Unknown opcode or directive: %s' % opcode)
275275
self.finalize_sections()
276276

277277
def assemble(self, text):

tests/assemble.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_assemble_uppercase_opcode():
125125
a = Assembler()
126126
try:
127127
a.assemble(" WAIT 42")
128-
except Exception as e:
128+
except ValueError as e:
129129
if str(e) != "Unknown opcode or directive: WAIT":
130130
# re-raise failures we didn't expect
131131
raise

0 commit comments

Comments
 (0)