Access display_value field with tableapi

[michaeldcanady]

❓ Question or Support Request

It looks like TableEntry's Value() has "value" hard coded as the inner map's key, so it looks like there is no way to access the other fields like display_value.

rb := tableapi.NewTableRequestBuilder(client, map[string]string{
  "table": "task_cmdb_ci_service",
  "baseurl": "...",
})

records, err := rb.Get(&tableapi.TableRequestBuilderGetParameters{
  Query: "task=my_sys_id",
  DisplayValue: tableapi.TRUE,
})

The above returns something like this :

&map[cmdb_ci_service:map[display_value:<What I want is here> link:...] ...]

From what I understand of the code, none of these inner fields can be accessed. Am I missing something ?
Thanks

[michaeldcanady]

For anyone else looking for this, setting ExcludeReferenceLink: true (which does not use tableapi.TRUE ?) gets rid of that internal map and makes Value() return the display value. If you don't need these other fields, that works

[michaeldcanady]

To answer your question, each value should be a TableEntry, so you can utilize the Get("") which will yield a TableValue from there you can use the ToX methods to get the value... or ideally that's how it would work, looking at it closer you'd only be able to get the key "value" so it'll need a rework to be more effective. Ideally something like:

entry.Get("").DisplayValue().ToX()
entry.Get(").Value().ToX()

[michaeldcanady]

Regarding the note about ExcludeReferenceLink not accepting tableapi.TRUE, it's because ExcludeReferenceLink requires a boolean value, while tableapi.TRUE is part of an enum for DisplayValue, which requires a string value of "true", "false", or "all".

I considered renaming tableapi.TRUE to tableapi.DisplayValueTrue to eliminate confusion and make it an integer enum for continuity. However, this would require a larger rework for the new type.

It might be best to settle for renaming it with the same type and string value.

[michaeldcanady]

Just merged PR #158 to improve the naming convention for the enums!

[michaeldcanady]

Rough PoC but I think this will work better than the current implementation:

type TableRecord interface {
     Get(“<field name>”) RecordElement
     Set(“<field name>”, <val>)
     HasAttribute(“<field name>”)
}

type RecordElement interface {
     GetDisplayValue() ElementValue
     GetValue() ElementValue
     GetLink() str
}

type ElementValue interface {
     GetInt64Value() *int64
     GetStringValue() *string
     GetBoolValue() *bool
     GetXValue() *X
}

[michaeldcanady]

@Ulrar I just created 1.7.0-RC1 to address this issue! It would be great if you could try it out and let me know if this is the experience you're expecting! Thank you!

[michaeldcanady]

Issue will be resolved in v1.7.1