Fixed api functions

Author: michaelchristopher-ui

api/http/healthcheck_test.go

@@ -28,7 +28,7 @@ func TestHealthCheck(t *testing.T) {
 		{
 			name: "Test if HealthCheck returns correct response",
 			mock: func() {
-				// No mocks needed for this simple function
+				mockLogger.EXPECT().NewInfo(gomock.Any()).Times(1)
 			},
 			assertions: func(res error, rec *httptest.ResponseRecorder) {
 				if assert.NoError(t, res) {

api/http/receivemessage.go

@@ -27,8 +27,8 @@ func (integrator *APIIntegrator) ReceiveMessage(c echo.Context) error {
 		ToUserID:   req.ToUserID,
 		Timestamp:  req.Timestamp,
 	})
-	if isOnline && err != nil {
-		integrator.Logger.NewError(fmt.Sprintf("[Integrator][ReceiveMesssage] Error when sending message to online user, err: %s", err.Error()))
+	if err != nil {
+		integrator.Logger.NewError(fmt.Sprintf("[Integrator][ReceiveMesssage] Error when sending message to user with ID %s, online: %v, err: %s", req.ToUserID, isOnline, err.Error()))
 		return c.JSON(http.StatusInternalServerError, structs.ErrorRet{
 			Error: err.Error(),
 		})

api/http/receivemessage_test.go

@@ -50,14 +50,15 @@ func TestReceiveMessage(t *testing.T) {
 					ToUserID:   "user2",
 					Timestamp:  "2025-04-02T06:53:00Z",
 				}).Return(true, nil).Times(1)
+				mockLogger.EXPECT().NewInfo(gomock.Any()).Times(1)
 			},
 			assertions: func(res error, rec *httptest.ResponseRecorder) {
 				if assert.NoError(t, res) {
 					assert.Equal(t, http.StatusOK, rec.Code)
 					expected, _ := json.Marshal(ReceiveMessageRes{
 						IsOnline: true,
 					})
-					assert.Equal(t, expected, rec.Body.String())
+					assert.Equal(t, string(expected)+"\n", rec.Body.String())
 				}
 			},
 		},
@@ -78,14 +79,15 @@ func TestReceiveMessage(t *testing.T) {
 					ToUserID:   "user2",
 					Timestamp:  "2025-04-02T06:53:00Z",
 				}).Return(false, nil).Times(1)
+				mockLogger.EXPECT().NewInfo(gomock.Any()).Times(1)
 			},
 			assertions: func(res error, rec *httptest.ResponseRecorder) {
 				if assert.NoError(t, res) {
 					assert.Equal(t, http.StatusOK, rec.Code)
 					expected, _ := json.Marshal(ReceiveMessageRes{
 						IsOnline: false,
 					})
-					assert.Equal(t, expected, rec.Body.String())
+					assert.Equal(t, string(expected)+"\n", rec.Body.String())
 				}
 			},
 		},
@@ -105,7 +107,8 @@ func TestReceiveMessage(t *testing.T) {
 					Type:       1,
 					ToUserID:   "user2",
 					Timestamp:  "2025-04-02T06:53:00Z",
-				}).Return(errors.New("foo")).Times(1)
+				}).Return(false, errors.New("foo")).Times(1)
+				mockLogger.EXPECT().NewError(gomock.Any()).Times(1)
 			},
 			assertions: func(res error, rec *httptest.ResponseRecorder) {
 				if assert.NoError(t, res) {
@@ -120,7 +123,9 @@ func TestReceiveMessage(t *testing.T) {
 		{
 			name:      "Test if wrong body returns error",
 			wrongBody: true,
-			mock:      func() {},
+			mock: func() {
+				mockLogger.EXPECT().NewError(gomock.Any()).Times(1)
+			},
 			assertions: func(res error, rec *httptest.ResponseRecorder) {
 				if assert.NoError(t, res) {
 					assert.Equal(t, http.StatusInternalServerError, rec.Code)

api/http/registeraccount.go

@@ -21,7 +21,7 @@ func (integrator APIIntegrator) RegisterAccount(c echo.Context) error {
 		})
 	}
 	//Validate password length. Since we're using BCrypt it must be 72 characters or less, starting from the 0 index.
-	if len(req.Password) < 72 {
+	if len(req.Password) > 72 {
 		integrator.Logger.NewInfo(fmt.Sprintf("[Integrator][RegisterAccount] Password is not shorter than 72 bytes, ID: %s", req.UserID))
 		return c.JSON(http.StatusBadRequest, structs.ErrorRet{
 			Error: "",

cmd/app/config.yaml

@@ -11,4 +11,4 @@ redis:
 
 database:
   dsn: "user:pass@tcp(mysql:3306)/db?charset=utf8mb4&parseTime=True&loc=Local"
-  pepper: "x"
+