Redis stable version updated, breaks redis-memory-server install

[RobertHunter-Pluto]

Install fails during npm ci or npm install. I assume this has something to do with their latest 8.0.0 release. Same issue happens if building inside a docker container or locally on a mac. Changing the redis version to anything starting with ^6 or ^7 fixes it.

This happens on both 0.10.0 and 0.12.1.

#0 52.97 npm error path /app/node_modules/redis-memory-server
#0 52.97 npm error command failed
#0 52.97 npm error command sh -c node ./scripts/postinstall
#0 52.97 npm error redis-memory-server: checking Redis binaries cache...
#0 52.97 npm error Downloading Redis stable: 0 % (0mb / 3.8mb)
#0 52.97 npm error failed to download/install Redis binaries. The error: Error: Command failed: make JEMALLOC_CONFIGURE_OPTS=--with-lg-vaddr=48
#0 52.97 npm error /bin/sh: 1: pkg-config: not found
#0 52.97 npm error /bin/sh: 1: pkg-config: not found
#0 52.97 npm error /bin/sh: 1: pkg-config: not found
#0 52.97 npm error     CC Makefile.dep
#0 52.97 npm error /bin/sh: 1: pkg-config: not found
#0 52.97 npm error /bin/sh: 1: pkg-config: not found
#0 52.97 npm error /bin/sh: 1: pkg-config: not found
#0 52.97 npm error make[3]: g++: No such file or directory
#0 52.97 npm error make[3]: *** [Makefile:18: fast_float_strtod.o] Error 127
#0 52.97 npm error make[2]: *** [Makefile:80: fast_float] Error 2
#0 52.97 npm error make[1]: [Makefile:402: persist-settings] Error 2 (ignored)
#0 52.97 npm error     CC threads_mngr.o
#0 52.97 npm error In file included from server.h:55,
#0 52.97 npm error                  from threads_mngr.c:16:
#0 52.97 npm error zmalloc.h:30:10: fatal error: jemalloc/jemalloc.h: No such file or directory
#0 52.97 npm error    30 | #include <jemalloc/jemalloc.h>
#0 52.97 npm error       |          ^~~~~~~~~~~~~~~~~~~~~
#0 52.97 npm error compilation terminated.
#0 52.97 npm error make[1]: *** [Makefile:454: threads_mngr.o] Error 1
#0 52.97 npm error make: *** [Makefile:11: all] Error 2```

[mhassan1]

I can't reproduce this issue on Mac for v8.0.0.

I see some errors in the output you posted: pkg-config: not found and g++: No such file or directory. Those indicate to me that you're missing build dependencies. On a Mac, you can try brew install pkg-config and xcode-select --install.

[Zahak]

I can reproduce, or well, get similar error as of Redis 8.0. By completely removing node_modules folder it tries to get latest stable (8.0) and then I get following error:

npm error code 1
npm error path /Users/----/Workspace/----/node_modules/redis-memory-server
npm error command failed
npm error command sh -c node ./scripts/postinstall
npm error redis-memory-server: checking Redis binaries cache...
npm error Downloading Redis stable: 0 % (0mb / 3.8mb)
npm error failed to download/install Redis binaries. The error: Error: Command failed: make JEMALLOC_CONFIGURE_OPTS=--with-lg-vaddr=48
npm error     CC Makefile.dep
npm error In file included from fast_float_strtod.cpp:1:
npm error ./fast_float.h:92:10: fatal error: 'cfloat' file not found
npm error    92 | #include <cfloat>
npm error       |          ^~~~~~~~
npm error 1 error generated.
npm error make[3]: *** [fast_float_strtod.o] Error 1
npm error make[2]: *** [fast_float] Error 2
npm error make[1]: [persist-settings] Error 2 (ignored)
npm error     CC threads_mngr.o
npm error     CC adlist.o
npm error     CC quicklist.o
npm error     CC ae.o
npm error     CC anet.o
npm error     CC dict.o
npm error     CC ebuckets.o
npm error     CC eventnotifier.o
npm error     CC iothread.o
npm error     CC mstr.o
npm error     CC kvstore.o
npm error     CC server.o
npm error     CC sds.o
npm error     CC zmalloc.o
npm error     CC lzf_c.o
npm error     CC lzf_d.o
npm error     CC pqsort.o
npm error     CC zipmap.o
npm error     CC sha1.o
npm error     CC ziplist.o
npm error     CC release.o
npm error     CC networking.o
npm error     CC util.o
npm error     CC object.o
npm error     CC db.o
npm error     CC replication.o
npm error     CC rdb.o
npm error     CC t_string.o
npm error     CC t_list.o
npm error     CC t_set.o
npm error     CC t_zset.o
npm error     CC t_hash.o
npm error     CC config.o
npm error     CC aof.o
npm error     CC pubsub.o
npm error     CC multi.o
npm error     CC debug.o
npm error     CC sort.o
npm error     CC intset.o
npm error     CC syncio.o
npm error     CC cluster.o
npm error     CC cluster_legacy.o
npm error     CC crc16.o
npm error     CC endianconv.o
npm error     CC slowlog.o
npm error     CC eval.o
npm error     CC bio.o
npm error     CC rio.o
npm error     CC rand.o
npm error     CC memtest.o
npm error     CC syscheck.o
npm error     CC crcspeed.o
npm error     CC crccombine.o
npm error     CC crc64.o
npm error     CC bitops.o
npm error     CC sentinel.o
npm error     CC notify.o
npm error     CC setproctitle.o
npm error     CC blocked.o
npm error     CC hyperloglog.o
npm error     CC latency.o
npm error     CC sparkline.o
npm error     CC redis-check-rdb.o
npm error     CC redis-check-aof.o
npm error     CC geo.o
npm error     CC lazyfree.o
npm error     CC module.o
npm error     CC evict.o
npm error     CC expire.o
npm error     CC geohash.o
npm error     CC geohash_helper.o
npm error     CC childinfo.o
npm error     CC defrag.o
npm error     CC siphash.o
npm error     CC rax.o
npm error     CC t_stream.o
npm error     CC listpack.o
npm error     CC localtime.o
npm error     CC lolwut.o
npm error     CC lolwut5.o
npm error     CC lolwut6.o
npm error     CC acl.o
npm error     CC tracking.o
npm error     CC socket.o
npm error     CC tls.o
npm error     CC sha256.o
npm error     CC timeout.o
npm error     CC setcpuaffinity.o
npm error     CC monotonic.o
npm error     CC mt19937-64.o
npm error     CC resp_parser.o
npm error     CC call_reply.o
npm error     CC script_lua.o
npm error     CC script.o
npm error     CC functions.o
npm error     CC function_lua.o
npm error     CC commands.o
npm error     CC strl.o
npm error     CC connection.o
npm error     CC unix.o
npm error     CC logreqres.o
npm error     CC hnsw.o
npm error     CC cJSON.o
npm error     CC vset.o
npm error     LINK redis-server
npm error clang: error: no such file or directory: '../deps/fast_float/libfast_float.a'
npm error make[1]: *** [redis-server] Error 1
npm error make: *** [all] Error 2

I've tried suggested brew install pkg-config and also xcode-select --install, but no success (xcode refers to software update). I'm currently running Mac OS 15.4.1.
Rest of team haven't encountered this issue, unclear why. We have compared our environments etc, but are unable to deduct why.

My workaround at the moment is to add configuration in package.json, in which case it works without issues:

"redisMemoryServer": {
    "version": "7.4.0"
  }

Node: v22.15.0
npm: 10.9.2

[llimllib]

I have several coworkers reporting the same npm error ./fast_float.h:92:10: fatal error: 'cfloat' file not found as the previous poster, but I also cannot reproduce unfortunately

edit:

One coworker with a failing build notes that they have g++ 16:

$ which g++
/usr/bin/g++
$ g++ --version
Apple clang version 16.0.0 (clang-1600.0.26.4)
Target: arm64-apple-darwin24.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

while I have g++ 17:

$ which g++
/usr/bin/g++
$ g++ --version
Apple clang version 17.0.0 (clang-1700.0.13.3)
Target: arm64-apple-darwin24.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I wonder if that's the difference?

[mhassan1]

@RobertHunter-Pluto You mentioned Docker; which base image are you using, and which toolchain packages are you installing?

@Zahak Can you also run g++ --version?

@llimllib Here's the PR where Redis introduced fast_float: redis/redis#11884. The fact that the PR had to fiddle with the toolchain makes me think that you might be on the right track. Does your coworker have the necessary packages mentioned here?

[RobertHunter-Pluto]

I'm using node:20-bullseye-slim, and then installing gcc, libcurl4, and make. Same issue happens with npm install directly on my mac with macOS 14.7.4. For the moment I'm just using redis 7.2.2 to make it work.

[Zahak]

I also have g++ 17.

But this isn't really a redis-memory-server issue as such. For instance, I notice that README in Redis 8.0.0 say:

Build and run Redis with all data structures - macOS 15 (Sequoia)

Support and instructions will be provided at a later date.

But well, after trying quite a lot of different things based on Redis README etc, I'm still stuck when it comes to version 8...

[mhassan1]

@RobertHunter-Pluto Regarding node:20-bullseye-slim, it sounds like you may just need to add g++ (link).

@Zahak Interesting... I am on Sequoia and I have no issue installing. I agree that it's not a redis-memory-server issue, but it would be great to figure it out. Please try this and post the output:

cd node_modules/.cache/redis-memory-server/redis-binaries/stable/extracted/deps/fast_float
# OR cd node_modules/.cache/redis-memory-server/redis-binaries/8.0.0/extracted/deps/fast_float

make clean
make

[RobertHunter-Pluto]

Thank you, I'll try that out with docker. I do still have the same issue on mac, and I have g++ 16 installed.

[Zahak]

@mhassan1 Totally agree 🙂

I tried:

➜  fast_float make clean
rm -f *.o
rm -f *.a
rm -f *.h.gch
rm -rf *.dSYM
➜  fast_float make
c++ -Wall -O3 -std=c++11 -DFASTFLOAT_ALLOWS_LEADING_PLUS -c fast_float_strtod.cpp 
In file included from fast_float_strtod.cpp:1:
./fast_float.h:92:10: fatal error: 'cfloat' file not found
   92 | #include <cfloat>
      |          ^~~~~~~~
1 error generated.
make: *** [fast_float_strtod.o] Error 1

[mhassan1]

@RobertHunter-Pluto @Zahak Please paste the output of this:

gcc -E -Wp,-v -xc /dev/null
# the results should include something like `/Library/Developer/CommandLineTools/usr/lib/clang/16/include`
ls -al /Library/Developer/CommandLineTools/usr/lib/clang/16/include/float.h

[Zahak]

ls -al /Library/Developer/CommandLineTools/usr/lib/clang/17/include/float.h 
-rw-r--r--  1 root  wheel  6415 Feb 28 10:01 /Library/Developer/CommandLineTools/usr/lib/clang/17/include/float.h

[mhassan1]

@Zahak Please try this and paste the full output:

cd node_modules/.cache/redis-memory-server/redis-binaries/stable/extracted/deps/fast_float
# OR cd node_modules/.cache/redis-memory-server/redis-binaries/8.0.0/extracted/deps/fast_float

# edit `fast_float.h`
# replace `<cfloat>` with `<float.h>`
# save

make clean
c++ -Wall -O3 -std=c++11 -DFASTFLOAT_ALLOWS_LEADING_PLUS -c fast_float_strtod.cpp -v

[Meyenehi]

Also having the same issue on MacOS Sequoia

[mhassan1]

@Meyenehi Please try #48 (comment) and paste the full output.

[Meyenehi]

Because npm install fails, I don't have a node_modules directory. If I run with --ignore-scripts so that it doesn't delete node_modules, it doesn't run the script to download redis