Merge in getter & setter fix

Author: mfederczuk

CHANGELOG.md

@@ -13,6 +13,10 @@ and this project adheres to [**Semantic Versioning v2.0.0**](https://semver.org/
 
 ## Unreleased ##
 
+### Fixed ###
+
+* Fixed objects with getters & setters
+
 ### Security ###
 
 * Update dependencies

src/deepFreeze.ts

@@ -6,13 +6,23 @@
 import { GenericKey } from "./types";
 import { canValueHaveProperties, getPropertyKeys } from "./_internal/utils";
 
+const deepFreezeKeysOfObject = (obj: Record<GenericKey, unknown>, keys: readonly GenericKey[]) => {
+	for (const key of keys) {
+		const descriptor: PropertyDescriptor = (Object.getOwnPropertyDescriptor(obj, key) as PropertyDescriptor);
+
+		deepFreeze(descriptor.get);
+		deepFreeze(descriptor.set);
+		deepFreeze(descriptor.value);
+	}
+};
+
+deepFreeze(deepFreezeKeysOfObject);
+
 const deepFreezePrototypeExcludingConstructor = (prototype: Record<GenericKey, unknown>) => {
 	const keys: GenericKey[] = getPropertyKeys(prototype)
 		.filter((key: GenericKey) => (key !== "constructor"));
 
-	for (const key of keys) {
-		deepFreeze((prototype[key]));
-	}
+	deepFreezeKeysOfObject(prototype, keys);
 };
 
 deepFreeze(deepFreezePrototypeExcludingConstructor);
@@ -78,9 +88,10 @@ function deepFreeze<T>(obj: T): Readonly<T> {
 		return deepFreezeFunctionWithPrototype(obj);
 	}
 
-	for (const key of getPropertyKeys(obj)) {
-		deepFreeze((obj as Record<GenericKey, unknown>)[key]);
-	}
+	deepFreezeKeysOfObject(
+		(obj as Record<GenericKey, unknown>),
+		getPropertyKeys(obj),
+	);
 
 	if ((obj instanceof Map) || (obj instanceof Set)) {
 		for (const [key, value] of obj.entries()) {

test/deepFreeze.ts

@@ -96,4 +96,38 @@ describe("function deepFreeze()", function() {
 		assert.strictEqual(foo.b[1].abc, 123);
 		assert.strictEqual(foo.b[1].xyz, "asd");
 	});
+
+	it("should work with object getters", function() {
+		const yVal: number = 64;
+
+		const obj = {
+			get x(): never {
+				throw new Error("Don't invoke me, bro");
+			},
+
+			get y(): number {
+				return yVal;
+			},
+		};
+
+		assert.doesNotThrow(() => {
+			deepFreeze(obj);
+		});
+	});
+
+	it("should work with object setters", function() {
+		const obj = {
+			set x(_: unknown) {
+				throw new Error("Don't invoke me either, bro");
+			},
+
+			set y(_: unknown) {
+				void _;
+			}
+		};
+
+		assert.doesNotThrow(() => {
+			deepFreeze(obj);
+		});
+	});
 });