Skip to content

Commit 0110c4b

Browse files
vlsunilKAGA-KOKO
authored andcommitted
irqchip/riscv-intc: Prevent memory leak when riscv_intc_init_common() fails
When riscv_intc_init_common() fails, the firmware node allocated is not freed. Add the missing free(). Fixes: 7023b9d ("irqchip/riscv-intc: Add ACPI support") Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Anup Patel <anup@brainfault.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20240527081113.616189-1-sunilvl@ventanamicro.com
1 parent c3f38fa commit 0110c4b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/irqchip/irq-riscv-intc.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,9 @@ IRQCHIP_DECLARE(andes, "andestech,cpu-intc", riscv_intc_init);
253253
static int __init riscv_intc_acpi_init(union acpi_subtable_headers *header,
254254
const unsigned long end)
255255
{
256-
struct fwnode_handle *fn;
257256
struct acpi_madt_rintc *rintc;
257+
struct fwnode_handle *fn;
258+
int rc;
258259

259260
rintc = (struct acpi_madt_rintc *)header;
260261

@@ -273,7 +274,11 @@ static int __init riscv_intc_acpi_init(union acpi_subtable_headers *header,
273274
return -ENOMEM;
274275
}
275276

276-
return riscv_intc_init_common(fn, &riscv_intc_chip);
277+
rc = riscv_intc_init_common(fn, &riscv_intc_chip);
278+
if (rc)
279+
irq_domain_free_fwnode(fn);
280+
281+
return rc;
277282
}
278283

279284
IRQCHIP_ACPI_DECLARE(riscv_intc, ACPI_MADT_TYPE_RINTC, NULL,

0 commit comments

Comments
 (0)