Skip to content

Commit c0188e5

Browse files
committed
Refactor loop variables
PR-URL: #370
1 parent c937487 commit c0188e5

File tree

3 files changed

+11
-19
lines changed

3 files changed

+11
-19
lines changed

lib/array.js

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ const map = (
3333
if (count === len) done(null, result);
3434
};
3535

36-
let i;
37-
for (i = 0; i < len; i++) {
36+
for (let i = 0; i < len; i++) {
3837
fn(items[i], next.bind(null, i));
3938
}
4039
};
@@ -72,17 +71,15 @@ const filter = (
7271
if (count === len) {
7372
const result = new Array(suitable);
7473
let pos = 0;
75-
let i, val;
76-
for (i = 0; i < len; i++) {
77-
val = data[i];
74+
for (let i = 0; i < len; i++) {
75+
const val = data[i];
7876
if (val !== rejected) result[pos++] = val;
7977
}
8078
done(null, result);
8179
}
8280
};
8381

84-
let i;
85-
for (i = 0; i < len; i++) {
82+
for (let i = 0; i < len; i++) {
8683
fn(items[i], next.bind(null, i));
8784
}
8885
};
@@ -161,8 +158,7 @@ const each = (
161158
if (count === len) done(null);
162159
};
163160

164-
let i;
165-
for (i = 0; i < len; i++) {
161+
for (let i = 0; i < len; i++) {
166162
fn(items[i], next);
167163
}
168164
};
@@ -228,8 +224,7 @@ const find = (
228224
if (index === last) done(null);
229225
};
230226

231-
let i;
232-
for (i = 0; i < len; i++) {
227+
for (let i = 0; i < len; i++) {
233228
fn(items[i], next.bind(null, i));
234229
}
235230
};
@@ -261,8 +256,7 @@ const every = (
261256
if (proceedItemsCount === len) done(null, true);
262257
};
263258

264-
let item;
265-
for (item of items) fn(item, finish);
259+
for (const item of items) fn(item, finish);
266260
};
267261

268262
const some = (

lib/composition.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,9 @@ Composition.prototype.parallel = function() {
119119
const fns = this.fns;
120120
const len = this.len;
121121
const context = this.context;
122-
let i, fn, fc;
123-
for (i = 0; i < len; i++) {
124-
fn = fns[i];
125-
fc = Array.isArray(fn) ? compose(fn) : fn;
122+
for (let i = 0; i < len; i++) {
123+
const fn = fns[i];
124+
const fc = Array.isArray(fn) ? compose(fn) : fn;
126125
fc(context, next);
127126
}
128127
};

lib/control.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ const parallel = (
4747
if (++counter === len) done(null, context);
4848
};
4949

50-
let fn;
51-
for (fn of fns) {
50+
for (const fn of fns) {
5251
// fn may be array of function
5352
const finish = finishFn.bind(null, fn);
5453
if (fn.length === 2) fn(context, finish);

0 commit comments

Comments
 (0)