Skip to content

Commit 63ec76f

Browse files
committed
Update parallel benchmarks (Promise + Compose)
* Don't create object every time in Promise resolve * Collect results in an array in Compose bench as it is dome in Promise.all
1 parent c8e5a62 commit 63ec76f

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

tests/load/parallel.compose.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const testCompose = done => {
2727
};
2828

2929
const f1 = metasync([[p1, p2, p3, p4, p5, p6]]);
30-
f1(done);
30+
f1([], done);
3131
};
3232

3333
benchmark.do(COUNT, [testCompose]);

tests/load/parallel.promise.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,25 @@ const benchmark = require('./benchmark.js');
77
const PromiseAll = done => {
88
let i = 0;
99
const p1 = new Promise(resolve => {
10-
setImmediate(() => resolve({ p1: ++i * 2 }));
10+
setImmediate(() => resolve(++i * 2));
1111
});
1212
const p2 = new Promise(resolve => {
13-
setImmediate(() => resolve({ p2: ++i * 3 }));
13+
setImmediate(() => resolve(++i * 3));
1414
});
1515
const p3 = new Promise(resolve => {
16-
setImmediate(() => resolve({ p3: ++i * 5 }));
16+
setImmediate(() => resolve(++i * 5));
1717
});
1818
const p4 = new Promise(resolve => {
19-
setImmediate(() => resolve({ p4: 'key ' + ++i }));
19+
setImmediate(() => resolve('key ' + ++i));
2020
});
2121
const p5 = new Promise(resolve => {
22-
setImmediate(() => resolve({ p5: ++i === 5 }));
22+
setImmediate(() => resolve(++i === 5));
2323
});
2424
const p6 = new Promise(resolve => {
25-
setImmediate(() => resolve({ p6: 'key' + ++i * 2 }));
25+
setImmediate(() => resolve('key' + ++i * 2));
2626
});
2727

28-
Promise.all([p1, p2, p3, p4, p5, p6]).then(res => done(null, res));
28+
Promise.all([p1, p2, p3, p4, p5, p6]).then(done.bind(null, null));
2929
};
3030

3131
benchmark.do(COUNT, [PromiseAll]);

0 commit comments

Comments
 (0)