generated from metaplex-foundation/solana-project-template
-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Description
Hi all! I'm updating the Anchor version in my repo to 0.31.1, which requires mpl-core version of 0.11.1-beta.2, and noticed that the discriminator of BaseAssetV1
has been changed from [0; 8]
to [1]
by this PR: #245. Two questions:
-
Would it be problematic to update programs that are currently running on older versions of Anchor and mpl-core?
-
The release note for Anchor 0.31.0 states the following:
Additionally, the IDL generation step also checks whether you have ambigious discriminators i.e. discriminators that can be used for multiple types. However, you should still consider future possibilities, especially when working with 1-byte discriminators. For example, having an account with discriminator [1] means you can't have any other discriminators that start with 1, e.g. [1, 2, 3, 4], as it would not be unique.
Now that the discriminator for BaseAssetV1
is [1]
, wouldn't this cause conflict if another account we define also starts with 1?
Thanks!
Metadata
Metadata
Assignees
Labels
No labels