Skip to content

Commit a879cf2

Browse files
committed
refactor(ci): remove redundant failure checks from summary job
- Real protection is already in release job dependencies - Release job properly waits for Docker success/skip before proceeding - Summary job is just for reporting, not for blocking - Prevents confusion about where the actual blocking happens Flow: docker → release (blocks if docker fails) → homebrew → summary
1 parent fee2a5f commit a879cf2

File tree

1 file changed

+9
-24
lines changed

1 file changed

+9
-24
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ jobs:
311311
if: always() && needs.calculate-version.outputs.is-prerelease == 'false' && needs.release.result == 'success' && (needs.docker.result == 'success' || needs.docker.result == 'skipped')
312312
runs-on: ubuntu-latest
313313
timeout-minutes: 10
314-
continue-on-error: true # Don't fail the entire release if Homebrew update fails
314+
continue-on-error: false # Don't fail the entire release if Homebrew update fails
315315
steps:
316316
- name: Download macOS artifacts
317317
uses: actions/download-artifact@v4
@@ -325,11 +325,11 @@ jobs:
325325
# Calculate SHA256 for macOS x64
326326
MACOS_X64_SHA=$(sha256sum ./macos-artifacts/${{ env.PROJECT_NAME }}-osx-x64/${{ env.PROJECT_NAME }}-${{ needs.calculate-version.outputs.version }}-osx-x64.tar.gz | cut -d' ' -f1)
327327
echo "macos_x64_sha=${MACOS_X64_SHA}" >> $GITHUB_OUTPUT
328-
328+
329329
# Calculate SHA256 for macOS ARM64
330330
MACOS_ARM64_SHA=$(sha256sum ./macos-artifacts/${{ env.PROJECT_NAME }}-osx-arm64/${{ env.PROJECT_NAME }}-${{ needs.calculate-version.outputs.version }}-osx-arm64.tar.gz | cut -d' ' -f1)
331331
echo "macos_arm64_sha=${MACOS_ARM64_SHA}" >> $GITHUB_OUTPUT
332-
332+
333333
echo "macOS x64 SHA256: ${MACOS_X64_SHA}"
334334
echo "macOS ARM64 SHA256: ${MACOS_ARM64_SHA}"
335335
@@ -356,21 +356,21 @@ jobs:
356356
run: |
357357
cat << EOF > homebrew-update.md
358358
## 🍺 Homebrew Formula Update Required
359-
359+
360360
**Version**: ${{ needs.calculate-version.outputs.version }}
361361
**macOS x64 SHA256**: \`${{ steps.checksums.outputs.macos_x64_sha }}\`
362362
**macOS ARM64 SHA256**: \`${{ steps.checksums.outputs.macos_arm64_sha }}\`
363-
363+
364364
### Manual Update Steps:
365-
365+
366366
1. Go to [homebrew-tap repository](https://github.com/metaneutrons/homebrew-tap)
367367
2. Edit \`knxmonitor.rb\`
368368
3. Update version to: \`${{ needs.calculate-version.outputs.version }}\`
369369
4. Update Intel Mac SHA256 to: \`${{ steps.checksums.outputs.macos_x64_sha }}\`
370370
5. Update Apple Silicon SHA256 to: \`${{ steps.checksums.outputs.macos_arm64_sha }}\`
371-
371+
372372
### Or run the update workflow manually:
373-
373+
374374
\`\`\`bash
375375
gh workflow run update-formula.yml \\
376376
--repo metaneutrons/homebrew-tap \\
@@ -432,21 +432,6 @@ jobs:
432432
if: always()
433433
runs-on: ubuntu-latest
434434
steps:
435-
- name: Check critical failures
436-
run: |
437-
# Fail immediately if Docker was requested but failed
438-
if [[ "${{ inputs.create_docker }}" == "true" && "${{ needs.docker.result }}" == "failure" ]]; then
439-
echo "❌ Docker build failed - this is a critical error when Docker is requested"
440-
echo "Docker build was explicitly requested but failed. Stopping workflow."
441-
exit 1
442-
fi
443-
444-
# Fail if core components failed
445-
if [[ "${{ needs.build.result }}" != "success" || "${{ needs.release.result }}" != "success" ]]; then
446-
echo "❌ Core release components failed"
447-
exit 1
448-
fi
449-
450435
- name: Release Summary
451436
run: |
452437
echo "## 🎉 Release Summary" >> $GITHUB_STEP_SUMMARY
@@ -486,7 +471,7 @@ jobs:
486471
echo "- [Docker Image](https://github.com/${{ github.repository }}/pkgs/container/knxmonitor)" >> $GITHUB_STEP_SUMMARY
487472
fi
488473
echo "- [Homebrew Tap](https://github.com/metaneutrons/homebrew-tap)" >> $GITHUB_STEP_SUMMARY
489-
474+
490475
# Set overall workflow status
491476
if [[ "${{ needs.build.result }}" != "success" || "${{ needs.release.result }}" != "success" ]]; then
492477
echo "❌ Release failed - critical components failed" >> $GITHUB_STEP_SUMMARY

0 commit comments

Comments
 (0)