Skip to content

Commit 7e7e88b

Browse files
committed
tag_is_(removable|editable)() -> _tag_is_(removable|editable)()
1 parent c8351b2 commit 7e7e88b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

picard/ui/metadatabox.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ def _paste_value(self):
330330
if item:
331331
column = item.column()
332332
tag = self.tag_diff.tag_names[item.row()]
333-
if column == self.COLUMN_NEW and self.tag_is_editable(tag):
333+
if column == self.COLUMN_NEW and self._tag_is_editable(tag):
334334
self._set_tag_values(tag, self.clipboard)
335335
self.update()
336336

@@ -366,7 +366,7 @@ def contextMenuEvent(self, event):
366366
single_tag = len(tags) == 1
367367
if single_tag:
368368
selected_tag = tags[0]
369-
editable = self.tag_is_editable(selected_tag)
369+
editable = self._tag_is_editable(selected_tag)
370370
edit_tag_action = QtGui.QAction(_("Edit…"), self)
371371
edit_tag_action.triggered.connect(partial(self._edit_tag, selected_tag))
372372
edit_tag_action.setShortcut(self.edit_tag_shortcut.key())
@@ -397,7 +397,7 @@ def contextMenuEvent(self, event):
397397
lookup_action = QtGui.QAction(_("Lookup in &Browser"), self)
398398
lookup_action.triggered.connect(partial(self._open_link, values, tag))
399399
menu.addAction(lookup_action)
400-
if self.tag_is_removable(tag):
400+
if self._tag_is_removable(tag):
401401
removals.append(partial(self._remove_tag, tag))
402402
status = self.tag_diff.status[tag] & TagStatus.CHANGED
403403
if status == TagStatus.CHANGED or status == TagStatus.REMOVED:
@@ -461,7 +461,7 @@ def _edit_tag(self, tag):
461461
EditTagDialog(self.parent, tag).exec()
462462

463463
def _edit_selected_tag(self):
464-
tags = self.selected_tags(filter_func=self.tag_is_editable)
464+
tags = self.selected_tags(filter_func=self._tag_is_editable)
465465
if len(tags) == 1:
466466
self._edit_tag(tags[0])
467467

@@ -476,7 +476,7 @@ def _set_tag_values(self, tag, values, objects=None):
476476
with self.parent.ignore_selection_changes:
477477
if values == [""]:
478478
values = []
479-
if not values and self.tag_is_removable(tag):
479+
if not values and self._tag_is_removable(tag):
480480
for obj in objects:
481481
del obj.metadata[tag]
482482
obj.update()
@@ -489,15 +489,15 @@ def _remove_tag(self, tag):
489489
self._set_tag_values(tag, [])
490490

491491
def remove_selected_tags(self):
492-
for tag in self.selected_tags(filter_func=self.tag_is_removable):
493-
if self.tag_is_removable(tag):
492+
for tag in self.selected_tags(filter_func=self._tag_is_removable):
493+
if self._tag_is_removable(tag):
494494
self._remove_tag(tag)
495495
self.parent.update_selection(new_selection=False, drop_album_caches=True)
496496

497-
def tag_is_removable(self, tag):
497+
def _tag_is_removable(self, tag):
498498
return self.tag_diff.status[tag] & TagStatus.NOTREMOVABLE == 0
499499

500-
def tag_is_editable(self, tag):
500+
def _tag_is_editable(self, tag):
501501
return self.tag_diff.status[tag] & TagStatus.READONLY == 0
502502

503503
def selected_tags(self, filter_func=None):

0 commit comments

Comments
 (0)