Fixed CheckboxListItem hiding QListWidgetItem.data()

Author: phw

picard/ui/checkbox_list_item.py

@@ -4,7 +4,7 @@
 #
 # Copyright (C) 2018 Sambhav Kothari
 # Copyright (C) 2018, 2020-2024 Laurent Monin
-# Copyright (C) 2022 Philipp Wolfer
+# Copyright (C) 2022, 2024 Philipp Wolfer
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -27,12 +27,10 @@
 
 class CheckboxListItem(QListWidgetItem):
 
-    def __init__(self, text='', checked=False, data=None):
-        super().__init__()
-        self.setText(text)
+    def __init__(self, text='', checked=False):
+        super().__init__(text)
         self.setFlags(self.flags() | Qt.ItemFlag.ItemIsUserCheckable)
         self.setCheckState(Qt.CheckState.Checked if checked else Qt.CheckState.Unchecked)
-        self.data = data
 
     @property
     def checked(self):

picard/ui/options/cover.py

@@ -3,7 +3,7 @@
 # Picard, the next-generation MusicBrainz tagger
 #
 # Copyright (C) 2006-2007 Lukáš Lalinský
-# Copyright (C) 2010, 2018-2021 Philipp Wolfer
+# Copyright (C) 2010, 2018-2021, 2024 Philipp Wolfer
 # Copyright (C) 2012, 2014 Wieland Hoffmann
 # Copyright (C) 2012-2014 Michael Wiencek
 # Copyright (C) 2013-2015, 2018-2021, 2023-2024 Laurent Monin
@@ -25,6 +25,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
+from PyQt6.QtCore import Qt
 
 from picard.config import (
     Option,
@@ -83,7 +84,8 @@ def _load_cover_art_providers(self):
         """
         self.ui.ca_providers_list.clear()
         for p in cover_art_providers():
-            item = CheckboxListItem(_(p.title), checked=p.enabled, data=p.name)
+            item = CheckboxListItem(_(p.title), checked=p.enabled)
+            item.setData(Qt.ItemDataRole.UserRole, p.name)
             self.ui.ca_providers_list.addItem(item)
 
     def load(self):
@@ -101,7 +103,7 @@ def load(self):
 
     def _ca_providers(self):
         for item in qlistwidget_items(self.ui.ca_providers_list):
-            yield (item.data, item.checked)
+            yield (item.data(Qt.ItemDataRole.UserRole), item.checked)
 
     def save(self):
         config = get_config()