Toggle one or more tags preserve state at once

Author: zas

picard/ui/metadatabox.py

@@ -385,16 +385,6 @@ def contextMenuEvent(self, event):
                 edit_tag_action.setShortcut(self.edit_tag_shortcut.key())
                 edit_tag_action.setEnabled(editable)
                 menu.addAction(edit_tag_action)
-                if selected_tag not in self.preserved_tags:
-                    add_to_preserved_tags_action = QtGui.QAction(_("Add to 'Preserve Tags' List"), self)
-                    add_to_preserved_tags_action.triggered.connect(partial(self.preserved_tags.add, selected_tag))
-                    add_to_preserved_tags_action.setEnabled(editable)
-                    menu.addAction(add_to_preserved_tags_action)
-                else:
-                    remove_from_preserved_tags_action = QtGui.QAction(_("Remove from 'Preserve Tags' List"), self)
-                    remove_from_preserved_tags_action.triggered.connect(partial(self.preserved_tags.discard, selected_tag))
-                    remove_from_preserved_tags_action.setEnabled(editable)
-                    menu.addAction(remove_from_preserved_tags_action)
             removals = []
             useorigs = []
             item = self.currentItem()
@@ -438,6 +428,11 @@ def contextMenuEvent(self, event):
                 remove_tag_action.setShortcut(self.remove_tag_shortcut.key())
                 remove_tag_action.setEnabled(bool(removals))
                 menu.addAction(remove_tag_action)
+
+                add_to_preserved_tags_action = QtGui.QAction(_("Toggle Preserve state"), self)
+                add_to_preserved_tags_action.triggered.connect(self._toggle_preserved)
+                menu.addAction(add_to_preserved_tags_action)
+
                 if useorigs:
                     name = ngettext("Use Original Value", "Use Original Values", len(useorigs))
                     use_orig_value_action = QtGui.QAction(name, self)
@@ -478,6 +473,14 @@ def _edit_selected_tag(self):
         if len(tags) == 1:
             self._edit_tag(tags[0])
 
+    def _toggle_preserved(self):
+        for tag in self._selected_tags(filter_func=self._tag_is_editable):
+            if tag in self.preserved_tags:
+                self.preserved_tags.discard(tag)
+            else:
+                self.preserved_tags.add(tag)
+        self.update()
+
     def _toggle_changes_first(self, checked):
         config = get_config()
         config.persist['show_changes_first'] = checked
@@ -685,12 +688,18 @@ def _update_items(self, result=None, error=None):
             if not tag_item:
                 tag_item = QtWidgets.QTableWidgetItem()
                 tag_item.setFlags(orig_flags)
-                font = tag_item.font()
-                font.setBold(True)
-                tag_item.setFont(font)
                 tag_item.setTextAlignment(alignment)
                 self.setItem(i, self.COLUMN_TAG, tag_item)
-            tag_item.setText(display_tag_name(tag))
+            text = display_tag_name(tag)
+            preserved = tag in self.preserved_tags
+            font = tag_item.font()
+            font.setBold(not preserved)
+            tag_item.setFont(font)
+            if preserved:
+                preserved_indicator_fmt = _('%s [P]')
+                tag_item.setText(preserved_indicator_fmt % text)
+            else:
+                tag_item.setText(text)
 
             orig_item = self.item(i, self.COLUMN_ORIG)
             if not orig_item: