tag_is_(removable|editable)() -> _tag_is_(removable|editable)()

Author: zas

picard/ui/metadatabox.py

@@ -329,7 +329,7 @@ def _paste_value(self):
         if item:
             column = item.column()
             tag = self.tag_diff.tag_names[item.row()]
-            if column == self.COLUMN_NEW and self.tag_is_editable(tag):
+            if column == self.COLUMN_NEW and self._tag_is_editable(tag):
                 self._set_tag_values(tag, self.clipboard)
                 self.update()
 
@@ -365,7 +365,7 @@ def contextMenuEvent(self, event):
             single_tag = len(tags) == 1
             if single_tag:
                 selected_tag = tags[0]
-                editable = self.tag_is_editable(selected_tag)
+                editable = self._tag_is_editable(selected_tag)
                 edit_tag_action = QtGui.QAction(_("Edit…"), self)
                 edit_tag_action.triggered.connect(partial(self._edit_tag, selected_tag))
                 edit_tag_action.setShortcut(self.edit_tag_shortcut.key())
@@ -396,7 +396,7 @@ def contextMenuEvent(self, event):
                             lookup_action = QtGui.QAction(_("Lookup in &Browser"), self)
                             lookup_action.triggered.connect(partial(self._open_link, values, tag))
                             menu.addAction(lookup_action)
-                    if self.tag_is_removable(tag):
+                    if self._tag_is_removable(tag):
                         removals.append(partial(self._remove_tag, tag))
                     status = self.tag_diff.status[tag] & TagStatus.CHANGED
                     if status == TagStatus.CHANGED or status == TagStatus.REMOVED:
@@ -459,7 +459,7 @@ def _edit_tag(self, tag):
         EditTagDialog(self.parent, tag).exec()
 
     def _edit_selected_tag(self):
-        tags = self.selected_tags(filter_func=self.tag_is_editable)
+        tags = self.selected_tags(filter_func=self._tag_is_editable)
         if len(tags) == 1:
             self._edit_tag(tags[0])
 
@@ -474,7 +474,7 @@ def _set_tag_values(self, tag, values, objects=None):
         with self.parent.ignore_selection_changes:
             if values == [""]:
                 values = []
-            if not values and self.tag_is_removable(tag):
+            if not values and self._tag_is_removable(tag):
                 for obj in objects:
                     del obj.metadata[tag]
                     obj.update()
@@ -487,15 +487,15 @@ def _remove_tag(self, tag):
         self._set_tag_values(tag, [])
 
     def remove_selected_tags(self):
-        for tag in self.selected_tags(filter_func=self.tag_is_removable):
-            if self.tag_is_removable(tag):
+        for tag in self.selected_tags(filter_func=self._tag_is_removable):
+            if self._tag_is_removable(tag):
                 self._remove_tag(tag)
         self.parent.update_selection(new_selection=False, drop_album_caches=True)
 
-    def tag_is_removable(self, tag):
+    def _tag_is_removable(self, tag):
         return self.tag_diff.status[tag] & TagStatus.NOTREMOVABLE == 0
 
-    def tag_is_editable(self, tag):
+    def _tag_is_editable(self, tag):
         return self.tag_diff.status[tag] & TagStatus.READONLY == 0
 
     def selected_tags(self, filter_func=None):