Skip to content

Commit 979805f

Browse files
bonzinidcbaker
authored andcommitted
coredata: remove unused arguments
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent 8dfecd2 commit 979805f

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

mesonbuild/ast/introspection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def _add_languages(self, raw_langs: T.List[TYPE_var], required: bool, for_machin
205205
else:
206206
continue
207207
if comp:
208-
self.coredata.process_compiler_options(lang, comp, self.environment, self.subproject)
208+
self.coredata.process_compiler_options(lang, comp, self.subproject)
209209

210210
def func_dependency(self, node: BaseNode, args: T.List[TYPE_var], kwargs: T.Dict[str, TYPE_var]) -> None:
211211
args = self.flatten_args(args)

mesonbuild/compilers/detect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def detect_compiler_for(env: 'Environment', lang: str, for_machine: MachineChoic
107107
if comp is None:
108108
return comp
109109
assert comp.for_machine == for_machine
110-
env.coredata.process_compiler_options(lang, comp, env, subproject)
110+
env.coredata.process_compiler_options(lang, comp, subproject)
111111
if not skip_sanity_check:
112112
comp.sanity_check(env.get_scratch_dir(), env)
113113
env.coredata.compilers[comp.for_machine][lang] = comp

mesonbuild/coredata.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -572,8 +572,7 @@ def set_options(self, opts_to_set: T.Dict[OptionKey, T.Any], subproject: str = '
572572

573573
return dirty
574574

575-
def add_compiler_options(self, c_options: MutableKeyedOptionDictType, lang: str, for_machine: MachineChoice,
576-
env: Environment, subproject: str) -> None:
575+
def add_compiler_options(self, c_options: MutableKeyedOptionDictType, lang: str, for_machine: MachineChoice) -> None:
577576
for k, o in c_options.items():
578577
assert k.subproject is None and k.machine is for_machine
579578
if lang == 'objc' and k.name == 'c_std':
@@ -594,8 +593,8 @@ def add_lang_args(self, lang: str, comp: T.Type['Compiler'],
594593
for gopt_key, gopt_valobj in compilers.get_global_options(lang, comp, for_machine, env).items():
595594
self.optstore.add_compiler_option(lang, gopt_key, gopt_valobj)
596595

597-
def process_compiler_options(self, lang: str, comp: Compiler, env: Environment, subproject: str) -> None:
598-
self.add_compiler_options(comp.get_options(), lang, comp.for_machine, env, subproject)
596+
def process_compiler_options(self, lang: str, comp: Compiler, subproject: str) -> None:
597+
self.add_compiler_options(comp.get_options(), lang, comp.for_machine)
599598

600599
for key in comp.base_options:
601600
if subproject:

mesonbuild/interpreter/interpreter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1531,7 +1531,7 @@ def add_languages_for(self, args: T.List[str], required: bool, for_machine: Mach
15311531
self.backend.allow_thin_archives[for_machine] = False
15321532
else:
15331533
# update new values from commandline, if it applies
1534-
self.coredata.process_compiler_options(lang, comp, self.environment, self.subproject)
1534+
self.coredata.process_compiler_options(lang, comp, self.subproject)
15351535

15361536
if for_machine == MachineChoice.HOST or self.environment.is_cross_build():
15371537
logger_fun = mlog.log

run_project_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,7 @@ def have_working_compiler(lang: str, use_tmp: bool) -> bool:
997997
return False
998998
if not compiler:
999999
return False
1000-
env.coredata.process_compiler_options(lang, compiler, env, '')
1000+
env.coredata.process_compiler_options(lang, compiler, '')
10011001
try:
10021002
compiler.sanity_check(env.get_scratch_dir(), env)
10031003
except mesonlib.MesonException:

0 commit comments

Comments
 (0)