refactor: remove unused variable

malhussan · meshkodiak[bot] · commit 010c517ea223 · 2022-04-27T08:42:21.000Z
diff --git a/main.tf b/main.tf
@@ -44,7 +44,6 @@ module "idp_lookup_service_principal" {
   source = "./modules/meshcloud-idp-lookup-service-principal/"
 
   service_principal_name_suffix = var.service_principal_name_suffix
-  scope                         = data.azurerm_management_group.root.id
 }
 
 module "uami_blueprint_user_principal" {
diff --git a/modules/meshcloud-idp-lookup-service-principal/variables.tf b/modules/meshcloud-idp-lookup-service-principal/variables.tf
@@ -2,8 +2,3 @@ variable "service_principal_name_suffix" {
   type        = string
   description = "Service principal name suffix."
 }
-
-variable "scope" {
-  type        = string
-  description = "The scope to which Service Principal permissions should be assigned to. Usually this is a management group that sits atop the subscriptions."
-}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ module "idp_lookup_service_principal" {`
`44`	`44`	`source = "./modules/meshcloud-idp-lookup-service-principal/"`
`45`	`45`
`46`	`46`	`service_principal_name_suffix = var.service_principal_name_suffix`
`47`		`- scope = data.azurerm_management_group.root.id`
`48`	`47`	`}`
`49`	`48`
`50`	`49`	`module "uami_blueprint_user_principal" {`
Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,3 @@ variable "service_principal_name_suffix" {`
`2`	`2`	`type = string`
`3`	`3`	`description = "Service principal name suffix."`
`4`	`4`	`}`
`5`		`-`
`6`		`-variable "scope" {`
`7`		`- type = string`
`8`		`- description = "The scope to which Service Principal permissions should be assigned to. Usually this is a management group that sits atop the subscriptions."`
`9`		`-}`